Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Angular Universal/Server Side Rendering Support #1108

Closed
dockleryxk opened this issue Aug 22, 2017 · 7 comments
Closed

[Request] Angular Universal/Server Side Rendering Support #1108

dockleryxk opened this issue Aug 22, 2017 · 7 comments
Labels

Comments

@dockleryxk
Copy link

In the past month, Angular Universal has become increasingly important because of SEO. I would love to be able to use this package again, but I can't as it stands currently.

Even if you were to make a mock component that could be rendered on the server side and then replaced in the browser, one could import the mock in the server module and the actual module in their browser module. I have been researching Universal very closely for the past week so let me know if you have questions. Again, I think it will be important to this project!

@lazarljubenovic
Copy link
Collaborator

A possible duplicate of #1052 (definitelly related, though).

@dockleryxk
Copy link
Author

Yeah, they are closely related (I didn't see that one, oops). The repo he forked is quite old though, because the error I am getting is on import, not export. Either way, very closely related.

@dockleryxk
Copy link
Author

I've done some more digging, and I am 99% sure that if this module was compiled to es5 it would work for universal.

@MichaelSolati
Copy link

MichaelSolati commented Aug 25, 2017

@dockleryxk oddly enough I didn't realize this was an issue but made a PR for it already in #1114

And yes this is related to #1052 from my experience.

@dockleryxk
Copy link
Author

Until this is resolved, I have it working with a workaround by dynamically loading a component that contains my agm-map based on if it's the browser or server: https://angular.io/guide/dynamic-component-loader

@stale
Copy link

stale bot commented Nov 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2018
@stale stale bot closed this as completed Nov 21, 2018
@dockleryxk
Copy link
Author

R.I.P.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants