Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Require minimum tally_gas_limit #252

Open
1 task
Thomasvdam opened this issue Jan 21, 2025 · 0 comments
Open
1 task

✨ Require minimum tally_gas_limit #252

Thomasvdam opened this issue Jan 21, 2025 · 0 comments
Labels
priority: low Should be fixed soon type: feature ✨ New feature or request

Comments

@Thomasvdam
Copy link
Member

✨ Feature

Since processing a DR takes computation on the chain side we're charging a base fee of 1Tgas (subject to change) before doing any custom tally logic (filter and/or VM execution). We should reject DRs that do not at least provide this base fee, since the result will always be an out of gas error for the requestor.

Motivation

Prevent requestors from posting DRs that can never produce a valid result since it's guaranteed to run out of gas if the minimum fee is not met.

Implementation

  • Figure out the best way to sync this value between the chain and the contract. Could be a module query, or if it's better/cheaper we keep it on the contract and the module gets it from there. A possibility would be alongside the list of DRs to be tallied, so we don't have to have an extra query.
@Thomasvdam Thomasvdam added the type: feature ✨ New feature or request label Jan 21, 2025
@mariocao mariocao added the priority: low Should be fixed soon label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Should be fixed soon type: feature ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants