Skip to content

Commit 123e97f

Browse files
Merge branch 'master' into layout-components-rc
2 parents 45006b1 + f1fe217 commit 123e97f

File tree

3 files changed

+38
-27
lines changed

3 files changed

+38
-27
lines changed

packages/braid-design-system/src/lib/components/Columns/Columns.docs.tsx

+6-6
Original file line numberDiff line numberDiff line change
@@ -443,9 +443,9 @@ const docs: ComponentDocs = {
443443
</Text>
444444
<Notice>
445445
<Text>
446-
Reversing is only applied in combination with the{' '}
447-
<Strong>collapseBelow</Strong> prop. This ensures the columns are
448-
reversed on the same row, and follow the document order when
446+
Reverse is only applied in combination with the{' '}
447+
<Strong>collapseBelow</Strong> prop to ensure the columns are
448+
reversed on the same row, but follow the document order when
449449
collapsed.
450450
</Text>
451451
</Notice>
@@ -517,11 +517,11 @@ const docs: ComponentDocs = {
517517
</>
518518
),
519519
code: source(
520-
<Columns space="small" component="ul">
521-
<Column component="li">
520+
<Columns space="small" component="span">
521+
<Column>
522522
<Placeholder height={40} />
523523
</Column>
524-
<Column component="li">
524+
<Column>
525525
<Placeholder height={40} />
526526
</Column>
527527
</Columns>,

packages/braid-design-system/src/lib/components/Columns/Columns.screenshots.tsx

+13
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,19 @@ export const screenshots: ComponentScreenshot = {
340340
</Columns>
341341
),
342342
},
343+
{
344+
label: 'Reverse',
345+
Example: () => (
346+
<Columns space="small" collapseBelow="tablet" reverse>
347+
<Column>
348+
<Placeholder height={60} label="First" />
349+
</Column>
350+
<Column>
351+
<Placeholder height={60} label="Second" />
352+
</Column>
353+
</Columns>
354+
),
355+
},
343356
{
344357
label:
345358
'Test: Collapsed "content" columns should be full width when setting "alignY"',

packages/braid-design-system/src/lib/components/Inline/Inline.docs.tsx

+19-21
Original file line numberDiff line numberDiff line change
@@ -220,21 +220,19 @@ const docs: ComponentDocs = {
220220
doubles as the screen reader order. The visual order can be flipped
221221
using the <Strong>reverse</Strong> prop.
222222
</Text>
223+
<Text>
224+
This is useful when navigating forward within a flow, where the
225+
primary action is on the right when inline, and on top when
226+
collapsed. For this reason, the default horizontal alignment when
227+
reversed is to the <Strong>right</Strong>.
228+
</Text>
223229
<Notice>
224-
<Stack space="medium">
225-
<Text>
226-
Reversing is only applied in combination with the{' '}
227-
<Strong>collapseBelow</Strong> prop. This ensures the content is
228-
reversed on the same row, and follow the document order when
229-
collapsed.
230-
</Text>
231-
<Text>
232-
This is useful when navigating forward within a flow, where the
233-
primary action is on the right when inline, and on top when
234-
collapsed. For this reason, the default the horizontal alignment
235-
when reversed is to the <Strong>right</Strong>.
236-
</Text>
237-
</Stack>
230+
<Text>
231+
Reverse is only applied in combination with the{' '}
232+
<Strong>collapseBelow</Strong> prop to ensure the content is
233+
reversed on the same row, but follows the document order when
234+
collapsed.
235+
</Text>
238236
</Notice>
239237
</>
240238
),
@@ -245,9 +243,9 @@ const docs: ComponentDocs = {
245243
<Text tone="secondary" size="small">
246244
On “tablet” and above
247245
</Text>
248-
<Inline space="small" collapseBelow="tablet" align="right">
249-
<Placeholder width={75} height={48} label="Second" />
250-
<Placeholder width={75} height={48} label="First" />
246+
<Inline space="small" align="right">
247+
<Placeholder height={48} label="Second" />
248+
<Placeholder height={48} label="First" />
251249
</Inline>
252250
</Stack>
253251
<Stack space="small">
@@ -264,8 +262,8 @@ const docs: ComponentDocs = {
264262

265263
const { code: codeDemo } = source(
266264
<Inline space="small" collapseBelow="tablet" reverse>
267-
<Placeholder width={75} height={48} label="First" />
268-
<Placeholder width={75} height={48} label="Second" />
265+
<Placeholder height={48} label="First" />
266+
<Placeholder height={48} label="Second" />
269267
</Inline>,
270268
);
271269

@@ -285,8 +283,8 @@ const docs: ComponentDocs = {
285283
),
286284
code: source(
287285
<Inline component="span" space="small">
288-
<Placeholder height={40} />
289-
<Placeholder height={40} />
286+
<Placeholder width={40} height={40} />
287+
<Placeholder width={40} height={40} />
290288
</Inline>,
291289
).code,
292290
},

0 commit comments

Comments
 (0)