wip

Author: silesky

packages/signals/signals-integration-tests/src/tests/custom-elements/custom-select.test.ts

@@ -3,7 +3,7 @@ import { waitForCondition } from '../../helpers/playwright-utils'
 import { IndexPage } from './index-page'
 import type { SegmentEvent } from '@segment/analytics-next'
 
-const basicEdgeFn = `globalThis.processSignal = (signal) => {}`
+const basicEdgeFn = `function processSignal(signal) {}`
 
 test('Collecting signals whenever a user selects an item', async ({ page }) => {
   const indexPage = await new IndexPage().loadAndWait(page, basicEdgeFn, {

packages/signals/signals-integration-tests/src/tests/custom-elements/custom-textfield.test.ts

@@ -2,7 +2,7 @@ import { test, expect } from '@playwright/test'
 import { waitForCondition } from '../../helpers/playwright-utils'
 import { IndexPage } from './index-page'
 
-const basicEdgeFn = `globalThis.processSignal = (signal) => {}`
+const basicEdgeFn = `function processSignal(signal) {}`
 
 test('Collecting signals whenever a user enters text input and focuses out', async ({
   page,

packages/signals/signals-integration-tests/src/tests/performance/memory-leak.test.ts

@@ -16,7 +16,7 @@ declare global {
 
 const basicEdgeFn = `
     // this is a process signal function
-    globalThis.processSignal = (signal) => {
+    function processSignal(signal) {
       if (signal.type === 'interaction') {
         const eventName = signal.data.eventType + ' ' + '[' + signal.type + ']'
         analytics.track(eventName, signal.data)

packages/signals/signals-integration-tests/src/tests/signals-vanilla/all-segment-events.test.ts

@@ -6,7 +6,6 @@ import { SegmentEvent } from '@segment/analytics-next'
 /**
  * This test ensures that
  */
-const indexPage = new IndexPage()
 
 const normalizeSnapshotEvent = (el: SegmentEvent) => {
   return {
@@ -35,9 +34,10 @@ const snapshot = (
 ).map(normalizeSnapshotEvent)
 
 test('Segment events', async ({ page }) => {
+  const indexPage = new IndexPage()
   const basicEdgeFn = `
     // this is a process signal function
-    globalThis.processSignal = (signal) => {
+    function processSignal(signal) {
       if (signal.type === 'interaction' && signal.data.eventType === 'click') {
         analytics.identify('john', { found: true })
         analytics.group('foo', { hello: 'world' })
@@ -61,11 +61,12 @@ test('Segment events', async ({ page }) => {
   expect(trackingApiReqs).toEqual(snapshot)
 })
 
-test('Should dispatch events from signals that occurred before analytics was instantiated', async ({
+test.only('Should dispatch events from signals that occurred before analytics was instantiated', async ({
   page,
 }) => {
+  const indexPage = new IndexPage()
   const edgeFn = `
-    globalThis.processSignal = (signal) => {
+    function processSignal(signal) {
        if (signal.type === 'navigation' && signal.data.action === 'pageLoad') {
           analytics.page('dispatched from signals - navigation')
       }
@@ -76,23 +77,25 @@ test('Should dispatch events from signals that occurred before analytics was ins
 
   await indexPage.load(page, edgeFn)
   const flush = Promise.all([
+    indexPage.addUserDefinedSignal(),
     indexPage.waitForSignalsApiFlush(),
     indexPage.waitForTrackingApiFlush(),
   ])
 
-  // add a user defined signal before analytics is instantiated
-  void indexPage.addUserDefinedSignal()
   await flush
 
   const trackingApiReqs = indexPage.trackingAPI.getEvents()
   expect(trackingApiReqs).toHaveLength(2)
 
   const pageEvents = trackingApiReqs.find((el) => el.type === 'page')!
+
   expect(pageEvents).toBeTruthy()
   expect(pageEvents.name).toEqual('dispatched from signals - navigation')
 
   const userDefinedEvents = trackingApiReqs.find((el) => el.type === 'track')!
-  expect(userDefinedEvents).toBeTruthy()
+  if (!userDefinedEvents) {
+    console.warn('invariant', trackingApiReqs)
+  }
   expect(userDefinedEvents.event).toEqual(
     'dispatched from signals - userDefined'
   )

packages/signals/signals-integration-tests/src/tests/signals-vanilla/basic.test.ts

@@ -4,7 +4,7 @@ import { IndexPage } from './index-page'
 
 const basicEdgeFn = `
     // this is a process signal function
-    globalThis.processSignal = (signal) => {
+    function processSignal(signal) {
       if (signal.type === 'interaction') {
         const eventName = signal.data.eventType + ' ' + '[' + signal.type + ']'
         analytics.track(eventName, signal.data)

packages/signals/signals-integration-tests/src/tests/signals-vanilla/button-click-complex.test.ts

@@ -1,7 +1,7 @@
 import { test, expect } from '@playwright/test'
 import { IndexPage } from './index-page'
 
-const basicEdgeFn = `globalThis.processSignal = (signal) => {}`
+const basicEdgeFn = `function processSignal(signal) {}`
 let indexPage: IndexPage
 test.beforeEach(async ({ page }) => {
   indexPage = await new IndexPage().loadAndWait(page, basicEdgeFn)

packages/signals/signals-integration-tests/src/tests/signals-vanilla/change-input.test.ts

@@ -2,7 +2,7 @@ import { test, expect } from '@playwright/test'
 import { waitForCondition } from '../../helpers/playwright-utils'
 import { IndexPage } from './index-page'
 
-const basicEdgeFn = `globalThis.processSignal = (signal) => {}`
+const basicEdgeFn = `function processSignal(signal) {}`
 
 test('Collecting signals whenever a user enters text input', async ({
   page,

packages/signals/signals-integration-tests/src/tests/signals-vanilla/middleware.test.ts

@@ -1,7 +1,7 @@
 import { test, expect } from '@playwright/test'
 import { IndexPage } from './index-page'
 
-const basicEdgeFn = `globalThis.processSignal = (signal) => {}`
+const basicEdgeFn = `function processSignal(signal) {}`
 
 let indexPage: IndexPage
 

packages/signals/signals-integration-tests/src/tests/signals-vanilla/network-signals-allow-list.test.ts

@@ -1,7 +1,7 @@
 import { test, expect } from '@playwright/test'
 import { IndexPage } from './index-page'
 
-const basicEdgeFn = `globalThis.processSignal = (signal) => {}`
+const basicEdgeFn = `function processSignal(signal) {}`
 
 test('network signals allow and disallow list', async ({ page }) => {
   const indexPage = await new IndexPage().loadAndWait(page, basicEdgeFn, {

packages/signals/signals-integration-tests/src/tests/signals-vanilla/network-signals-fetch.test.ts

@@ -2,7 +2,7 @@ import { test, expect } from '@playwright/test'
 import { commonSignalData } from '../../helpers/fixtures'
 import { IndexPage } from './index-page'
 
-const basicEdgeFn = `globalThis.processSignal = (signal) => {}`
+const basicEdgeFn = `function processSignal(signal) {}`
 
 test.describe('network signals - fetch', () => {
   let indexPage: IndexPage