Remove unused taskID. (#119)

bsneed · Brandon Sneed · web-flow · commit 32e6e4c2d549 · 2022-02-16T13:45:35.000-08:00
* Remove unused taskID.

* Remove use of taskID

* Restructure test failure expectation

Co-authored-by: Brandon Sneed &lt;brandon.sneed@segment.com&gt;
diff --git a/Sources/Segment/Plugins/Platforms/iOS/iOSLifecycleMonitor.swift b/Sources/Segment/Plugins/Platforms/iOS/iOSLifecycleMonitor.swift
@@ -195,7 +195,6 @@ extension SegmentDestination.UploadTaskInfo {
                 task.cancel()
                 application.endBackgroundTask(taskIdentifier)
             }
-            self.taskID = taskIdentifier.rawValue
             
             self.cleanup = {
                 application.endBackgroundTask(taskIdentifier)
diff --git a/Sources/Segment/Plugins/SegmentDestination.swift b/Sources/Segment/Plugins/SegmentDestination.swift
@@ -36,7 +36,6 @@ public class SegmentDestination: DestinationPlugin {
         let task: URLSessionDataTask
         // set/used via an extension in iOSLifecycleMonitor.swift
         typealias CleanupClosure = () -> Void
-        var taskID: Int = 0
         var cleanup: CleanupClosure? = nil
     }
     
diff --git a/Tests/Segment-Tests/Analytics_Tests.swift b/Tests/Segment-Tests/Analytics_Tests.swift
@@ -100,8 +100,9 @@ final class Analytics_Tests: XCTestCase {
         
         analytics.track(name: "testDestinationEnabled")
         
-        XCTExpectFailure()
-        wait(for: [expectation], timeout: 1.0)
+        XCTExpectFailure {
+            wait(for: [expectation], timeout: 1.0)
+        }
     }
     #endif
     

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,6 @@ extension SegmentDestination.UploadTaskInfo {`
`195`	`195`	`task.cancel()`
`196`	`196`	`application.endBackgroundTask(taskIdentifier)`
`197`	`197`	`}`
`198`		`- self.taskID = taskIdentifier.rawValue`
`199`	`198`
`200`	`199`	`self.cleanup = {`
`201`	`200`	`application.endBackgroundTask(taskIdentifier)`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ public class SegmentDestination: DestinationPlugin {`
`36`	`36`	`let task: URLSessionDataTask`
`37`	`37`	`// set/used via an extension in iOSLifecycleMonitor.swift`
`38`	`38`	`typealias CleanupClosure = () -> Void`
`39`		`- var taskID: Int = 0`
`40`	`39`	`var cleanup: CleanupClosure? = nil`
`41`	`40`	`}`
`42`	`41`
Original file line number	Diff line number	Diff line change
`@@ -100,8 +100,9 @@ final class Analytics_Tests: XCTestCase {`
`100`	`100`
`101`	`101`	`analytics.track(name: "testDestinationEnabled")`
`102`	`102`
`103`		`- XCTExpectFailure()`
`104`		`- wait(for: [expectation], timeout: 1.0)`
	`103`	`+ XCTExpectFailure {`
	`104`	`+ wait(for: [expectation], timeout: 1.0)`
	`105`	`+ }`
`105`	`106`	`}`
`106`	`107`	`#endif`
`107`	`108`