Skip to content

Commit 2ec3f5b

Browse files
Don't fail CI builds on lint warnings (#530)
1 parent a9cfd67 commit 2ec3f5b

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.buildkite/pipeline.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ steps:
55
command:
66
- npm config set "//registry.npmjs.org/:_authToken" $${NPM_TOKEN}
77
- yarn install --frozen-lockfile
8-
- yarn lint
8+
- yarn lint || true
99
- yarn test
1010
- yarn test:ci
1111
plugins:

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ jobs:
9393
command: yarn install --frozen-lockfile
9494
- run:
9595
name: Run Linter (not enforcing for now)
96-
command: yarn lint
96+
command: yarn lint || true
9797
- run:
9898
name: Run Tests
9999
command: yarn test

.eslintrc

+4-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@
1717
"no-shadow": "warn",
1818
"no-plusplus": "off",
1919
"no-template-curly-in-string": "warn",
20-
"no-useless-escape": "warn"
20+
"no-useless-escape": "warn",
21+
"no-return-assign": "warn",
22+
"no-unused-vars": "warn",
23+
"no-param-reassign": "warn"
2124
},
2225
"overrides": [
2326
{

0 commit comments

Comments
 (0)