Skip to content

Commit 159dfaa

Browse files
committed
remove string value helper function
1 parent 2dc7bb2 commit 159dfaa

1 file changed

Lines changed: 3 additions & 10 deletions

File tree

pkg/admin/zkclient.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,9 @@ func (c *ZKAdminClient) GetBrokers(
257257
if !ok {
258258
continue
259259
}
260-
brokers[b].InstanceID = stringValue(instance.InstanceId)
260+
brokers[b].InstanceID = aws.ToString(instance.InstanceId)
261261
brokers[b].InstanceType = string(instance.InstanceType)
262-
brokers[b].AvailabilityZone = stringValue(
262+
brokers[b].AvailabilityZone = aws.ToString(
263263
instance.Placement.AvailabilityZone,
264264
)
265265
}
@@ -1089,7 +1089,7 @@ func (c *ZKAdminClient) getInstances(
10891089
for _, reservation := range resp.Reservations {
10901090
for _, instance := range reservation.Instances {
10911091
for _, networkInterface := range instance.NetworkInterfaces {
1092-
privateIP := stringValue(networkInterface.PrivateIpAddress)
1092+
privateIP := aws.ToString(networkInterface.PrivateIpAddress)
10931093

10941094
if _, ok := ipsMap[privateIP]; ok {
10951095
instancesMap[privateIP] = instance
@@ -1180,10 +1180,3 @@ func (c *ZKAdminClient) GetAllTopicsMetadata(
11801180

11811181
return metadata, nil
11821182
}
1183-
1184-
func stringValue(s *string) string {
1185-
if s != nil {
1186-
return *s
1187-
}
1188-
return ""
1189-
}

0 commit comments

Comments
 (0)