Visual Studio 17.8 build failure

[davidbolvansky]

Newer Visual Studio 17.8+ C++ STL deprecates the use of checked_array_iterator with this change
microsoft/STL#3818

This causes a build error due to the deprecation if warnings are treated as errors.

[tigercosmos]

@davidbolvansky Thanks for the information. We will consider to make a patch for it. Feel free to submit a PR as well!

[davidbolvansky]

Workaround for now:
add_compile_options(-D_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING)

[tigercosmos]

Nice, but it's better to address it from the source.

[clementperon]

@davidbolvansky could you point which VLA is causing the issue ?

Maybe you can open a MR and follow what has been done for FreeBSD
e5f6911

[seladb]

@davidbolvansky are you sure this is still happening?

We're using windows-2022 in our CI which uses Visual Studio 17.13 and the build passes 🤔

[seladb]

@davidbolvansky I'll close this issue now; if the issue persists, please feel free to re-open it