Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NomiCakes is not restoring frame registered for TRADE_SKILL_SHOW #1

Open
b-morgan opened this issue Mar 5, 2021 · 2 comments
Open

Comments

@b-morgan
Copy link

b-morgan commented Mar 5, 2021

I see the code to do it but apparently, its not getting called. I was a bit surprised to not see the event TRADE_SKILL_CLOSE used for cleanup.

@b-morgan
Copy link
Author

b-morgan commented Mar 5, 2021

The following patch appears to work. I added restoring the registrations after you close the trade skill. I also experimented with adding the TRADE_SKILL_CLOSE event. This patch can probably be improved (like moving the restore instead of duplicating it).

NomiCakes.txt

@b-morgan
Copy link
Author

b-morgan commented Mar 7, 2021

Here's a better patch that uses the TRADE_SKILL_CLOSE event.

NomiCakes.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant