Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable simdjson test in ci.yml #184

Open
scottbot95 opened this issue Jul 16, 2023 · 2 comments
Open

Re-enable simdjson test in ci.yml #184

scottbot95 opened this issue Jul 16, 2023 · 2 comments
Labels
just needs work There is nothing left to discuss or decide, someone just needs to do it (probably me at some point)

Comments

@scottbot95
Copy link
Contributor

The simdjson test was disabled in 1b0f83b due to upstream issues with the serenity/simdjson (serenity-rs/serenity#2474). Once upstream issues are resolved, we should re-enable the simdjson test.
@scottbot95 scottbot95 mentioned this issue Aug 12, 2023
Merged
@kangalio kangalio added the blocked on serenity Depends on a feature from serenity that is yet to be released on crates.io label Aug 30, 2023
@kangalio kangalio added just needs work There is nothing left to discuss or decide, someone just needs to do it (probably me at some point) and removed blocked on serenity Depends on a feature from serenity that is yet to be released on crates.io labels Dec 12, 2023
@jamesbt365
Copy link
Member

We have removed simd-json in serenity-rs/serenity#2735 on the next branch. Is this still valid (current still has it but is there any purpose to getting it to work if it still doesn't)?

@scottbot95
Copy link
Contributor Author

I don't think we need to re-enable this test anymore if we've removed simd-json entirely. Probably should cleanup the workflow though and any other references to simd-json

poise/.github/workflows/ci.yml

Line 47 in 6c26be9

- name: all features - simdjson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
just needs work There is nothing left to discuss or decide, someone just needs to do it (probably me at some point)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scottbot95 @kangalio @jamesbt365