-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply edit without reset embed #300
Comments
I've found this to be strange too. Though I can see one issue - given existing embeds are kept, there's no way to just clear out all embeds explicitly if this was changed with the current API. Maybe add fn embeds(&self, embeds: Vec<serenity::CreateEmbed>) -> Self {
self.embeds = Some(embeds);
self
} that allows the list to be set explicitly? And then replace the existing embed fn with something like pub fn embed(mut self, embed: serenity::CreateEmbed) -> Self {
self.embeds.get_or_insert_with(|| Vec::capacity(1)).push(embed);
self
}
|
Fixes serenity-rs#300 # Conflicts: # src/reply/builder.rs
Fixes serenity-rs#300 # Conflicts: # src/reply/builder.rs
Why embeds on reply edit always replaced and not made as
allowed_mentions
for example?Because of that I can't just edit components without not cloning previous embeds.
poise/src/reply/builder.rs
Lines 174 to 178 in 5750259
UPD.
Okay, I found that for
CreateReply
fieldembeds
is notOption
. Why?The text was updated successfully, but these errors were encountered: