Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary simd-json feature gate #252

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

GnomedDev
Copy link
Member

This was missed in #228.

@GnomedDev GnomedDev changed the title Remove unneccessary simd-json feature gate Remove unnecessary simd-json feature gate Sep 7, 2024
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, these look good to me. CI failures are primarily because some commits on current have yet to be upstreamed. Feel free to merge when you're ready.

@GnomedDev
Copy link
Member Author

I'll merge after a next rebase, later on today.

@GnomedDev GnomedDev merged commit 92314a1 into serenity-rs:next Sep 9, 2024
10 checks passed
@GnomedDev GnomedDev deleted the remove-feature-gate branch September 9, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants