-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal requirements check #31
Comments
Maybe it's anoying for a user to get all the mails. So you could test if $to = '[email protected]';
$subject = 'the subject';
$message = 'hello';
if(mail($to, $subject, $message){
echo "mail() enabled"; //but mail will not be delivered
} else {
echo "mail() disabled";
} |
I wanted to send email as a second layer of checking - the mail server can be misconfigured and the mail function would still return true, which would be a problem for users who forget their passwords for example 🙂 |
Ah, yeah then it's the best to send a mail to the user. |
If are the requirements, it were not hard (for me) to write a bash script to check this and write the results in a file |
AFAIK this all can also be checked in PHP without any major problems, I just didn't have the time to write the script yet. Now my finals are almost over so I expect to look into it sometime soon 🙂 |
@Pryx ah ok, I could write that short script, but if you make it in PHP directly, than it make more sense^^ |
Would something like this do for basic prerequsite checks during installation? The example checks the following three points:
Other checks can be easily added if needed. I haven't commited the update yet, so the diff to install.php is: The end result looks like this This should fix #35 as well. |
* Add prerequisite checks to install script. - #31 * Add option to use existing URL for privacy policy. #41 - Also moved the gitbug icon to the left of the footer as it looked like it was part of the imprint/policy link. - Fixed Imprint & Privacy policy text so that it will be translated. * Admin page is redirected to wrong URL on save. Fix #67
We should check (ideally both before install and in administration every time) for minimal requirements - #18 will surely need CURL to work and we should check if
mail()
function exists and is working. Maybe send testing email with "Welcome" information right after install? I don't think server memory or max script run time will be problem (yet). Also maybe checking write permission before trying to write config file could be nice. If anyone has more ideas what to check, let me know.The text was updated successfully, but these errors were encountered: