You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug 1985509 - Update bindgen to fix overaligned types on x86. r=nika,supply-chain-reviewers,profiler-reviewers,canaltinova
Bindgen historically represented 8-byte aligned types with u64. That's
borked in x86 where u64 is 4-byte aligned.
I fixed this in upstream bindgen
(rust-lang/rust-bindgen#3280), so update it.
There are a few changes needed:
* mozilla/neqo#2913 to deal with the now
properly aligned type.
* Similar change (less fun because transmute, but still sound) in the
macos crash reporter. I could try to generate a bit easier to use
bindings for 8-byte 8-byte-aligned blobs, but this would do.
* Some opaque additions in layout/style/ServoBindings.toml and the
profiler bindings. This is unrelated to the opaque change, but
fallout from other bindgen improvements. In particular, layout tests
now run at compile time, so this uncovered some layout mismatches on
platforms where we don't run rusttests on CI.
Differential Revision: https://phabricator.services.mozilla.com/D262840
0 commit comments