Feature/slow mode whitelisst #1751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
55
to
58
| var showWhitelistEnableDialog by mutableStateOf(false) | ||
| var showWhitelistDisableDialog by mutableStateOf(false) | ||
|
|
||
| var whiteListControl: SwitchPreferenceCompat? = null |
Collaborator
There was a problem hiding this comment.
Can these be private?
|
|
||
| var whiteListControl: SwitchPreferenceCompat? = null | ||
|
|
||
| private val composeView by lazy { ComposeView(requireContext()) } |
Collaborator
There was a problem hiding this comment.
I think we shouldn't retain views in fragments because fragment will create/destroy view as necessary. So it should be:
private var composeView: ComposeView? = null
then create and assign it in onCreateView
| startActivity(intent) // shows the system dialog for this specific app | ||
| } catch (_: ActivityNotFoundException) { | ||
| // Fallback to the general settings list | ||
| startActivity(Intent(Settings.ACTION_IGNORE_BATTERY_OPTIMIZATION_SETTINGS)) |
Collaborator
There was a problem hiding this comment.
Can ActivityNotFoundException happen to this too?
Collaborator
Author
There was a problem hiding this comment.
It probably can on some custom ROMs. I'll try the basic settings and then show a toast if even that fails
SessionHero01
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-4975 - New UI to help users with Slow Mode to make sure Session is whitelisted as allowed to run in the background.