fix: ensure lfs screenshots are always pulled

chore: debug risk level

try to debug lfs issues

fix: ensure screenshots in lfs are always downloaded

chore: remove debugging artifacts

Author: Miki-Session

.github/workflows/android-regression.yml

@@ -110,6 +110,40 @@ jobs:
         with:
           lfs: true
 
+      # This is necessary because the macOS runner was not always pulling the lfs files despite checkout with lfs: true 
+      # Check if LFS files were actually pulled 
+      - name: Verify LFS files 
+        run: |
+          echo "Ensuring all LFS screenshot files are downloaded..."
+          git lfs pull --include="run/screenshots/**/*.png"
+          
+          echo "=== Verifying screenshot files ==="
+          corrupted_files=0
+          total_files=0
+          
+          for file in run/screenshots/**/*.png; do
+            if [[ -f "$file" ]]; then  # Make sure file exists (in case glob doesn't match anything)
+              ((total_files++))
+              if file "$file" | grep -q "PNG image"; then
+                echo "✅ $file"
+              else
+                echo "⚠️  WARNING: $file is not a PNG image - related tests may fail"
+                # Show what it actually is for debugging
+                echo "   File type: $(file "$file")"
+                ((corrupted_files++))
+              fi
+            fi
+          done
+          
+          echo "📊 Screenshot verification: $((total_files - corrupted_files))/$total_files files valid"
+          
+          if [ $corrupted_files -gt 0 ]; then
+            echo "⚠️ Found $corrupted_files corrupted screenshot files"
+            echo "📝 Tests using these files will be skipped or may fail"
+          else
+            echo "✅ All screenshot files are valid PNG images"
+          fi
+
       - name: Fetch result history from gh-pages
         uses: ./github/actions/fetch-allure-history
         if: ${{ env.ALLURE_ENABLED == 'true' }}

run/test/specs/utils/verify_screenshots.ts

@@ -60,21 +60,32 @@ export async function verifyElementScreenshot<
   const elementScreenshotBase64: string = await device.getElementScreenshot(
     elementToScreenshot.ELEMENT
   );
+
   // Convert the base64 string to a Buffer and save it to disk as a png
   const elementScreenshotPath = path.join(diffsDir, `${uuid}_screenshot.png`);
   const screenshotBuffer = Buffer.from(elementScreenshotBase64, 'base64');
+
   fs.writeFileSync(elementScreenshotPath, screenshotBuffer);
+
   // Check if baseline screenshot exists
   const baselineScreenshotPath = element.screenshotFileName(...args);
   if (!fs.existsSync(baselineScreenshotPath)) {
     throw new Error(
       `No baseline image found at: ${baselineScreenshotPath}. A new screenshot has been saved at: ${elementScreenshotPath}`
     );
   }
+
+  // Fail loudly if LFS pointer has not been resolved correctly 
+  const baselineBuffer = fs.readFileSync(baselineScreenshotPath);
+  if (baselineBuffer.toString('utf8', 0, 50).includes('version https://git-lfs')) {
+  throw new Error(`Baseline is corrupted LFS pointer: ${baselineScreenshotPath}. Skipping visual test.`);
+}
+
   // Use looks-same to verify the element screenshot against the baseline
   const { equal, diffImage } = await looksSame(elementScreenshotPath, baselineScreenshotPath, {
     createDiffImage: true,
   });
+
   if (!equal) {
     const diffImagePath = path.join(diffsDir, `${uuid}_diffImage.png`);
     await diffImage.save(diffImagePath);