Skip to content

Bookmark::fromArray does not save custom data set by plugins on save_link #1808

@Kdecherf

Description

@Kdecherf

The new Bookmark object and its service introduced in v0.12 remove custom data set by save_link plugin hooks.

This behavior has two drawbacks:

  1. All custom data set when saving new links are lost (e.g. with the provided demo_plugin)
  2. All custom data set on links saved with previous versions of Shaarli are lost when updateMethodMigrateDatabase is executed

Bookmark::fromArray() should support a custom key to let plugins add again custom data.

Example of plugins saving custom data on links: via

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugit's broken!help-wantedhelp-wantedpluginbells and whistles

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions