Skip to content

[bug]: base-vega submenu triggers use data-open instead of data-popup-open #11361

Description

@meetdhruva

Affected components

  • context-menuContextMenuSubTrigger
  • menubarMenubarSubTrigger (via DropdownMenuSubTrigger)

Problem

The current base-vega registry emits data-open:bg-accent data-open:text-accent-foreground on submenu triggers:

Base UI exposes data-popup-open on Menu.SubmenuTrigger when its submenu is open, not data-open. The equivalent context-menu trigger has the same attribute contract.

https://base-ui.com/react/components/menu

As a result, the generated open-submenu trigger styling does not activate.

Expected change

Replace the trigger selectors with:

data-popup-open:bg-accent data-popup-open:text-accent-foreground

data-open should remain on popup/content elements, where it is correct.

Reproduction

  1. Initialize or configure a project with style: "base-vega".
  2. Add context-menu or menubar.
  3. Open a submenu and observe that its trigger does not receive the generated open styling.

I verified this against the current registry payload and @base-ui/react data-attribute declarations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions