-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DX12 coopvec tests on CI #6250
Comments
When I used the dxcompiler.dll, I observed crash on one of runners, When I debugged with visual studio, the call stack looked almost same to one of known issues on DXC repo. The suggested solution is to upgrade MSVC runtime binaries of v143. But the same solution didn't work for another runner, |
To reproduce the issue, I used the following steps,
|
I realized that there is a build configuration called "MinSizeRel" when compiling dxcompiler.dll |
It seems like there was one more problem for enabling dx12 coopvec tests.
Annoyingly and strangely, just replacing dxcompiler.dll and dxil.dll causes a few tests to fail. And it looks like enabling "DX12 experimental feature" itself is not as easy as I thought. |
It looks like when "DX12 experimental feature" is enabled, I cannot run wgpu tests with DX12 together. I cannot reproduce it on my local machine. I start to think that the initialization of dxcompiler.dll may have bugs when multiple processes try to initialize simultaneously. |
I think the "DX12 experimental feature" should be turned on only when needed. |
When I locally tested on each runner machine with RDP, I got a few tests failures. The command I used it
I used commit "a4b538282c5d8ffc6ce2f54597c132d11a52edd2" for the testing. [SLANGWIN10X64-1]
[SlangWin10-2]
[SlangWin4-2]
[SLANGWIN5]
[horde]
|
When I ran the same test on my local machine, three tests are failing,
I guess these may actually have problems. And I also noticed that the following three tests are expected to fail.
That means the following tests are the only ones failed unexpectedly. [SLANGWIN10X64-1]
[SLANGWIN5]
[horde]
|
I identified problems on the 100% failing tests and prepared a fix.
I am looking into failing Falcor tests. |
There are 12 failing Falcor tests.
https://github.com/shader-slang/slang/actions/runs/13173367844/job/36767538167?pr=6302 I am not sure how many will fail on the Falcor image test too. |
Here are the error messages for each failing Falcor test: AABBTests.cpp:AABB (D3D12)
BSDFTests.cpp:TestBsdf_DiffuseSpecularBRDF (D3D12)
BSDFTests.cpp:TestBsdf_DisneyDiffuseBRDF (D3D12)
BSDFTests.cpp:TestBsdf_FrostbiteDiffuseBRDF (D3D12)
BSDFTests.cpp:TestBsdf_LambertDiffuseBRDF (D3D12)
BSDFTests.cpp:TestBsdf_LambertDiffuseBTDF (D3D12)
BSDFTests.cpp:TestBsdf_OrenNayarBRDF (D3D12)
BSDFTests.cpp:TestBsdf_SheenBSDF (D3D12)
BSDFTests.cpp:TestBsdf_SpecularMicrofacetBRDF (D3D12)
GeometryHelpersTests.cpp:BoxSubtendedConeAngleAverage (D3D12)
GeometryHelpersTests.cpp:BoxSubtendedConeAngleAverageRandoms (D3D12)
GeometryHelpersTests.cpp:ComputeRayOrigin (D3D12)
It appears that all of error messages are from a same problem. |
Until the issue is resolved, we cannot upgrade dxcompiler.dll to support coopvec. Because if we upgrade without addressing the problem, upgrading dxcompiler.dll will be a breaking change, which we should avoid. |
DXC repo that supports coopvec is released publicly.
https://github.com/NVIDIA-RTX/DirectXShaderCompiler/tree/CooperativeVector
We should start using dxcompiler.dll from the repo and enable the related tests.
The text was updated successfully, but these errors were encountered: