From b90e950bc7e048cc5aedc41569c9f408a8e833de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Velad=20Galv=C3=A1n?= Date: Tue, 4 Mar 2025 14:13:20 +0100 Subject: [PATCH] chore: Remove older version of Chrome in layout tests (#8208) The current version is 133, so it is safe to make this change. --- test/test/util/layout_tests.js | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/test/test/util/layout_tests.js b/test/test/util/layout_tests.js index 2376060c63..05ba5d1de2 100644 --- a/test/test/util/layout_tests.js +++ b/test/test/util/layout_tests.js @@ -178,7 +178,7 @@ shaka.test.TextLayoutTests = class extends shaka.test.LayoutTests { // We only trust Safari for native text layout tests if explicitly flagged. // We only do this in our lab, where we control device a11y settings that // impact these tests heavily. - if (shaka.util.Platform.safariVersion() && + if (shaka.util.Platform.isApple() && !getClientArg('trustSafariNativeTextLayout')) { return false; } @@ -188,13 +188,6 @@ shaka.test.TextLayoutTests = class extends shaka.test.LayoutTests { return false; } - // Due to updates in the rendering and/or default styles in Chrome, the - // screenshots for native rendering only match in Chrome 106+. - const chromeVersion = shaka.util.Platform.chromeVersion(); - if (chromeVersion && chromeVersion < 106) { - return false; - } - return true; }