-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEA-708 - commands P16 #7926
Labels
component: captions/subtitles
The issue involves captions or subtitles
priority: P2
Smaller impact or easy workaround
type: bug
Something isn't working correctly
Milestone
Comments
avelad
added a commit
to avelad/shaka-player
that referenced
this issue
Jan 23, 2025
avelad
added a commit
to avelad/shaka-player
that referenced
this issue
Jan 23, 2025
avelad
added a commit
that referenced
this issue
Jan 23, 2025
avelad
added a commit
that referenced
this issue
Jan 23, 2025
avelad
added a commit
that referenced
this issue
Jan 23, 2025
joeyparrish
pushed a commit
that referenced
this issue
Feb 22, 2025
Fixes #7926 Backported to v4.9.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: captions/subtitles
The issue involves captions or subtitles
priority: P2
Smaller impact or easy workaround
type: bug
Something isn't working correctly
Have you read the FAQ and checked for duplicate open issues?
Yes, #7829 #7837
If the problem is related to FairPlay, have you read the tutorial?
No
What version of Shaka Player are you using?
v4.12.8
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from
main
?yes
Are you using the demo app or your own custom app?
demo
If custom app, can you reproduce the issue using our demo app?
What browser and OS are you using?
MacOS 15.2, Chrome 131.0.6778.266
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://mtoczko.github.io/hls-test-streams/test-cea708-p16/playlist.m3u8
https://mtoczko.github.io/hls-test-streams/test-cea708-p16/captions.txt
What configuration are you using? What is the output of
player.getNonDefaultConfiguration()
?What did you do?
What did you expect to happen?
Correctly decode captions 708 from a sample stream containing characters outside of G0.
Stream contains alphabets from the languages POL, CZE, SVK, RUS, UKR, BLR, BGR, SRB, MKD, GRC, HUN, EST, LVA, LTU, TUR, IRL, FIN, ALB
Show all details
What actually happened?
Function prevents proper decoding of unicode
0x18 0x01 0x7c
=>Unicode 17c
=>ż
shaka-player/lib/cea/cea708_service.js
Lines 174 to 176 in 0df53d2
Are you planning to send a PR to fix it?
No
The text was updated successfully, but these errors were encountered: