Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideUI method should close also the menues (such as quality selector, overflow menu, captions menu) #8224

Open
MarianoFacundoArch opened this issue Mar 7, 2025 · 2 comments
Labels
type: bug Something isn't working correctly
Milestone

Comments

@MarianoFacundoArch
Copy link
Contributor

This phenomenon happens in all releases, including the online demos.

When we call the method
hideUI() of the ui controls, it hides the main UI but not any menu that was opened by that UI.
I tried also the hideSettingsMenu as documented in

https://github.com/shaka-project/shaka-player/blob/main/ui/controls.js

But it does not do the trick. So currently I think (unless I am missing something) there is no programmatic way of truly hiding the entire UI.

@MarianoFacundoArch MarianoFacundoArch added the type: bug Something isn't working correctly label Mar 7, 2025
@shaka-bot shaka-bot added this to the v4.14 milestone Mar 7, 2025
@MarianoFacundoArch
Copy link
Contributor Author

Some bug seems to be related. When I send the hideUI() to an iOS, the controls are not being hidden for some reason. And in Android, in some cases either is not hidden. I imagine for some reason one of the conditions is triggering. Maybe the hideUI should trigger no matter what if called (unless the video is paused or stop, or in those states where displaying the controls must actually be prioritized)

@MarianoFacundoArch
Copy link
Contributor Author

I confirm, the programmatic hide UI only works for desktop.
When in mobile, it is not working. Maybe some of the conditions, like detecting a touch event or something, are fired, but it does not hide the UI. UI hides after some seconds with no interaction, even if we send the event to hide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants