Playback speed options reversed

[efb4f5ff-1298-471a-8973-3d47447115dc]

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not applicable

What version of Shaka Player are you using?

4.13.4

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes, nightly demo

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Firefox, Win11

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable

What are the manifest and license server URIs?

Any will work as this is a UI bug.

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Default

What did you do?

Prerequisite, add code snippet:

document.getElementById('video').ui.configure({ playbackRates: [2, 1.5, 1, 0.5] })

1. Open any video in the demo player
2. Go to the playback rate menu
3. See that playback rates sorted low to high

What did you expect to happen?
Playback rate should be sorted high to low when i configure it that way. This was always the case in versions < 4.13.2. Also didnt see anything about this change in the changelog

What actually happened?

Playback rate is always being forced to sort low to high now

Are you planning to send a PR to fix it?
No but all that would need to be done code wise is removing the .sort() call from this line: https://github.com/shaka-project/shaka-player/blob/main/ui/playback_rate_selection.js#L112

This was the PR that changed it, it didn't appear in the changelog as it is tagged as a chore: #8028