refactor: improve i2c peripherals responsiveness

Author: paradajz

app/firmware/src/io/i2c/instance/impl/deps.h

@@ -108,6 +108,16 @@ namespace opendeck::firmware::io::i2c
          */
         virtual bool update() = 0;
 
+        /**
+         * @brief Returns the compile-time update interval for this peripheral.
+         *
+         * @return Minimum time between update() calls in milliseconds.
+         */
+        virtual int64_t update_interval_ms()
+        {
+            return 1;
+        }
+
         /**
          * @brief Returns the peripheral name used in diagnostics.
          *

app/firmware/src/io/i2c/instance/impl/i2c.cpp

@@ -135,8 +135,9 @@ void I2c::update_peripheral(PeripheralState& state, int64_t now_ms)
                 return;
             }
 
-            state.address_index = address_index.value();
-            state.initialized   = peripheral->init(state.address_index);
+            state.address_index  = address_index.value();
+            state.initialized    = peripheral->init(state.address_index);
+            state.next_update_ms = now_ms;
 
             if (!state.initialized)
             {
@@ -151,10 +152,24 @@ void I2c::update_peripheral(PeripheralState& state, int64_t now_ms)
         }
     }
 
-    if (state.initialized && !peripheral->update())
+    if (!state.initialized)
+    {
+        return;
+    }
+
+    if (now_ms < state.next_update_ms)
+    {
+        return;
+    }
+
+    state.next_update_ms = now_ms + peripheral->update_interval_ms();
+
+    if (!peripheral->update())
     {
         LOG_WRN("I2C peripheral %s update failed, deinitializing", peripheral->name().data());
         peripheral->deinit();
-        state.initialized = false;
+        state.initialized    = false;
+        state.next_probe_ms  = now_ms + DEVICE_PROBE_INTERVAL_MS;
+        state.next_update_ms = 0;
     }
 }

app/firmware/src/io/i2c/instance/impl/i2c.h

@@ -54,10 +54,11 @@ namespace opendeck::firmware::io::i2c
 
         struct PeripheralState
         {
-            Peripheral* instance      = nullptr;
-            bool        initialized   = false;
-            size_t      address_index = 0;
-            int64_t     next_probe_ms = 0;
+            Peripheral* instance       = nullptr;
+            bool        initialized    = false;
+            size_t      address_index  = 0;
+            int64_t     next_probe_ms  = 0;
+            int64_t     next_update_ms = 0;
         };
 
         static inline std::vector<PeripheralState> peripherals = {};

app/firmware/src/io/i2c/peripherals/sensor_apds9960/instance/impl/common.h

@@ -73,7 +73,7 @@ namespace opendeck::firmware::io::i2c::sensor_apds9960
     constexpr inline uint8_t APDS9960_CONTROL_LED_DRIVE_SHIFT      = 6;
     constexpr inline uint8_t APDS9960_CONTROL_PROXIMITY_GAIN_SHIFT = 2;
 
-    constexpr inline uint8_t  APDS9960_DEFAULT_ATIME          = 219;
+    constexpr inline uint8_t  APDS9960_DEFAULT_ATIME          = 246;
     constexpr inline uint8_t  APDS9960_DEFAULT_WTIME          = 246;
     constexpr inline uint8_t  APDS9960_DEFAULT_PPULSE         = 0x87;
     constexpr inline uint8_t  APDS9960_DEFAULT_POFFSET_UR     = 0;