buttons: add a new mmc play/stop message type

Author: paradajz

src/firmware/application/io/buttons/buttons.cpp

@@ -256,6 +256,7 @@ void Buttons::sendMessage(size_t index, bool state, Descriptor& descriptor)
         case messageType_t::MMC_STOP:
         case messageType_t::MMC_PAUSE:
         case messageType_t::MMC_RECORD:
+        case messageType_t::MMC_PLAY_STOP:
             break;
 
         case messageType_t::PROGRAM_CHANGE:
@@ -470,6 +471,12 @@ void Buttons::sendMessage(size_t index, bool state, Descriptor& descriptor)
         }
         break;
 
+        case messageType_t::MMC_PLAY_STOP:
+        {
+            descriptor.event.message = midi::messageType_t::MMC_STOP;
+        }
+        break;
+
         default:
         {
             send = false;
@@ -584,6 +591,7 @@ void Buttons::fillDescriptor(size_t index, Descriptor& descriptor)
     break;
 
     case messageType_t::MMC_RECORD:
+    case messageType_t::MMC_PLAY_STOP:
     {
         descriptor.type = type_t::LATCHING;
     }

src/firmware/application/io/buttons/buttons.h

@@ -94,6 +94,7 @@ namespace io::buttons
             midi::messageType_t::INVALID,                         // PROGRAM_CHANGE_OFFSET_DEC
             midi::messageType_t::INVALID,                         // BPM_INC
             midi::messageType_t::INVALID,                         // BPM_DEC
+            midi::messageType_t::MMC_PLAY,                        // MMC_PLAY_STOP - modified to stop when needed
         };
 
         Hwa&      _hwa;

src/firmware/application/io/buttons/common.h

@@ -67,6 +67,7 @@ namespace io::buttons
         PROGRAM_CHANGE_OFFSET_DEC,
         BPM_INC,
         BPM_DEC,
+        MMC_PLAY_STOP,
         AMOUNT
     };
 }    // namespace io::buttons

tests/src/io/buttons/test.cpp

@@ -707,4 +707,41 @@ TEST_F(ButtonsTest, PresetChange)
     ASSERT_EQ(0, _listener._event.size());
 }
 
+TEST_F(ButtonsTest, MMCStartStop)
+{
+    if (!buttons::Collection::SIZE(buttons::GROUP_DIGITAL_INPUTS))
+    {
+        return;
+    }
+
+    MidiDispatcher.listen(messaging::eventType_t::SYSTEM,
+                          [this](const messaging::Event& dispatchMessage)
+                          {
+                              _listener.messageListener(dispatchMessage);
+                          });
+
+    // configure one button to MMC_PLAY_STOP message type
+    static constexpr size_t BUTTON_INDEX = 0;
+
+    ASSERT_TRUE(_buttons._database.update(database::Config::Section::button_t::MESSAGE_TYPE, BUTTON_INDEX, buttons::messageType_t::MMC_PLAY_STOP));
+    _buttons._instance.reset(BUTTON_INDEX);
+
+    // simulate button press
+    stateChangeRegisterSingle(BUTTON_INDEX, true);
+
+    ASSERT_EQ(1, _listener._event.size());
+    ASSERT_EQ(midi::messageType_t::MMC_PLAY, _listener._event.at(0).message);
+
+    // verify that no new events are generated on button release
+    stateChangeRegisterSingle(BUTTON_INDEX, false);
+    ASSERT_EQ(0, _listener._event.size());
+
+    // simulate a new button press
+    stateChangeRegisterSingle(BUTTON_INDEX, true);
+
+    // the message should be MMC_STOP now
+    ASSERT_EQ(1, _listener._event.size());
+    ASSERT_EQ(midi::messageType_t::MMC_STOP, _listener._event.at(0).message);
+}
+
 #endif