style: fix lint issues

Author: paradajz

app/firmware/src/io/i2c/peripherals/sensor_apds9960/instance/impl/common.h

@@ -6,6 +6,7 @@
 #pragma once
 
 #include <array>
+#include <cstddef>
 #include <cstdint>
 
 namespace opendeck::firmware::io::i2c::sensor_apds9960
@@ -73,6 +74,9 @@ namespace opendeck::firmware::io::i2c::sensor_apds9960
     constexpr inline uint8_t APDS9960_CONTROL_LED_DRIVE_SHIFT      = 6;
     constexpr inline uint8_t APDS9960_CONTROL_PROXIMITY_GAIN_SHIFT = 2;
 
+    constexpr inline int64_t APDS9960_UPDATE_INTERVAL_MS = 30;
+    constexpr inline size_t  APDS9960_LIGHT_DATA_SIZE    = 8;
+
     constexpr inline uint8_t  APDS9960_DEFAULT_ATIME          = 246;
     constexpr inline uint8_t  APDS9960_DEFAULT_WTIME          = 246;
     constexpr inline uint8_t  APDS9960_DEFAULT_PPULSE         = 0x87;

app/firmware/src/io/i2c/peripherals/sensor_apds9960/instance/impl/mapper.cpp

@@ -26,8 +26,6 @@ Mapper::Result Mapper::proximity_result(uint8_t value) const
 
 Mapper::Result Mapper::ambient_light_result(uint16_t value) const
 {
-    const auto info = read_database_info();
-
     return {
         .osc = {
             .payload = opendeck::firmware::signaling::OscSensorAmbientLightSignal{
@@ -40,8 +38,6 @@ Mapper::Result Mapper::ambient_light_result(uint16_t value) const
 
 Mapper::Result Mapper::rgb_result(uint16_t red, uint16_t green, uint16_t blue) const
 {
-    const auto info = read_database_info();
-
     return {
         .osc = {
             .payload = opendeck::firmware::signaling::OscSensorRgbSignal{

app/firmware/src/io/i2c/peripherals/sensor_apds9960/instance/impl/sensor_apds9960.cpp

@@ -174,7 +174,7 @@ constexpr std::string_view SensorApds9960::name() const
 
 int64_t SensorApds9960::update_interval_ms()
 {
-    return 30;
+    return APDS9960_UPDATE_INTERVAL_MS;
 }
 
 std::span<const uint8_t> SensorApds9960::i2c_addresses() const
@@ -258,17 +258,17 @@ bool SensorApds9960::read_ambient_light_and_rgb(uint8_t status)
         return true;
     }
 
-    std::array<uint8_t, 8> light = {};
+    std::array<uint8_t, APDS9960_LIGHT_DATA_SIZE> light = {};
 
     if (!read_register_block(APDS9960_REGISTER_CDATAL, std::span<uint8_t>(light)))
     {
         return recoverable_i2c_read_failure();
     }
 
-    const auto ambient_light = sys_get_le16(&light[0]);
-    const auto red           = sys_get_le16(&light[2]);
-    const auto green         = sys_get_le16(&light[4]);
-    const auto blue          = sys_get_le16(&light[6]);
+    const auto ambient_light = sys_get_le16(light.data());
+    const auto red           = sys_get_le16(light.data() + 2);
+    const auto green         = sys_get_le16(light.data() + 4);
+    const auto blue          = sys_get_le16(light.data() + 6);
 
     if (ambient_light_enabled &&
         _ambient_light_filter.update({ ambient_light },

app/firmware/src/io/i2c/peripherals/sensor_vl53l4cx/instance/impl/sensor_vl53l4cx.cpp

@@ -25,6 +25,7 @@ namespace
     constexpr uint32_t RESPONSE_FAST_TIMING_BUDGET_US     = 33333;
     constexpr uint32_t RESPONSE_BALANCED_TIMING_BUDGET_US = 66000;
     constexpr uint32_t RESPONSE_STABLE_TIMING_BUDGET_US   = 100000;
+    constexpr uint32_t MICROSECONDS_PER_MILLISECOND       = 1000;
     constexpr int32_t  SOFT_RESET_DELAY_MS                = 100;
     constexpr uint8_t  SOFT_RESET_ASSERTED                = 0x00;
     constexpr uint8_t  SOFT_RESET_RELEASED                = 0x01;
@@ -59,7 +60,7 @@ namespace
 
         const auto timing_budget_us = response_timing_budget_us(response);
 
-        return static_cast<int64_t>((timing_budget_us + SCAN_MARGIN) / 1000);
+        return static_cast<int64_t>((timing_budget_us + SCAN_MARGIN) / MICROSECONDS_PER_MILLISECOND);
     }
 
     constexpr VL53L4CX_DistanceModes driver_distance_mode(DistanceMode mode)