Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider documenting the "location" of a node #134

Open
bakkot opened this issue Nov 27, 2018 · 0 comments
Open

Consider documenting the "location" of a node #134

bakkot opened this issue Nov 27, 2018 · 0 comments

Comments

@bakkot
Copy link
Member

bakkot commented Nov 27, 2018

Followup to #69:

Various tools (e.g shift-parser-js) provide a way of querying the location corresponding to a node in some source text. We might consider saying what that means, at least for edge cases, such as:

  • do FormalParameters include parentheses?
  • do Programs include leading and/or trailing whitespace? what about when there are no non-whitespace tokens?
  • where do grouping parentheses go? e.g. in (a + b);, are they in the BinaryExpression or the ExpressionStatement?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant