Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the type of TemplateExpression #145

Open
bakkot opened this issue Feb 17, 2021 · 0 comments
Open

Improve the type of TemplateExpression #145

bakkot opened this issue Feb 17, 2021 · 0 comments

Comments

@bakkot
Copy link
Member

bakkot commented Feb 17, 2021

TemplateExpression has

interface TemplateExpression : Expression {
  attribute Expression? tag;
  attribute (Expression or TemplateElement)[] elements;
}

but that's imprecise: the elements must alternate, be nonempty, and begin and end with TemplateElement. A better type would be

interface TemplatePart {
  attribute Expression expression;
  attribute TemplateElement string;
}
interface TemplateExpression : Expression {
  attribute Expression? tag;
  attribute TemplateElement first;
  attribute TemplatePart[] parts;
}

which represents precisely the legal templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant