Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add level prefix to splitted baseline files #27

Closed
staabm opened this issue Dec 23, 2024 · 4 comments
Closed

add level prefix to splitted baseline files #27

staabm opened this issue Dec 23, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@staabm
Copy link
Contributor

staabm commented Dec 23, 2024

I think it would be helpful if the splitted baseline files would have a "level0-10" prefix.

as a PHPStan end-user people usually don't know which identifier belong to which level and therefore it would be helpful to see lower level errors, which often times when fixed have a high impact on the number of upper level errors

@janedbal janedbal added the enhancement New feature or request label Dec 23, 2024
@janedbal
Copy link
Member

That is quite opinionated (the levels are IMO too). So I dont think I would implement this. So this falls into the bucket of "customization not possible" (see the idea)

@staabm
Copy link
Contributor Author

staabm commented Dec 23, 2024

alternatively, maybe the level could be printed into the comment of each baseline?

atm it reads
# total 122 errors

but could read like e.g.
# total 122 errors (level 0)

@janedbal
Copy link
Member

# total 122 errors (level 0)

I can imagine that, if you send PR with that, I'll accept it.

@staabm
Copy link
Contributor Author

staabm commented Feb 12, 2025

level information is not available in phpstan-src

@staabm staabm closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants