-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathtest_api_flows.py
More file actions
871 lines (700 loc) · 34.7 KB
/
test_api_flows.py
File metadata and controls
871 lines (700 loc) · 34.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
"""
Tests for MoltMarkets API endpoints and trading flows.
Covers the full lifecycle:
1. Register agent → verify response
2. Create market → verify fields
3. Place bet (YES/NO) → verify balance changes, probability shifts
4. Sell position → verify payout with fees
5. Resolve market → verify winner payouts
6. Edge cases: bet on closed market, insufficient balance, invalid market ID
Uses FastAPI TestClient against the in-memory storage backend
(DATABASE_URL is not set, so Storage falls back to dicts).
Run with: python -m pytest test_api_flows.py -v
Ref: https://github.com/shirtlessfounder/moltmarkets-api/issues/52
"""
import os
import uuid
from datetime import datetime, timedelta, timezone
import pytest
from fastapi.testclient import TestClient
# ---------------------------------------------------------------------------
# Ensure in-memory storage (no DATABASE_URL) before importing app
# ---------------------------------------------------------------------------
os.environ.pop("DATABASE_URL", None)
from api import app, db # noqa: E402
from deps import STARTING_BALANCE, TRADE_FEE_RATE # noqa: E402
from rate_limiter import rate_limiter # noqa: E402
# ---------------------------------------------------------------------------
# Helpers
# ---------------------------------------------------------------------------
def _fresh_storage():
"""Reset the global in-memory storage between tests."""
db._markets.clear()
db._users.clear()
db._bets.clear()
db._positions.clear()
if hasattr(db, "_comments"):
db._comments.clear()
if hasattr(db, "_resolution_votes"):
db._resolution_votes.clear()
if hasattr(db, "_chat_messages"):
db._chat_messages.clear()
# Reset rate limiter so tests don't hit 429s from prior runs
rate_limiter._requests.clear()
rate_limiter._call_count = 0
# Re-create the demo user the lifespan event would normally create
if not db.get_user("demo-user"):
db.create_user("demo-user", "demo_user", balance=0.0)
def _register_agent(client: TestClient, username: str = None, description: str = "") -> dict:
"""Register an agent and return (user_data, api_key, auth_header)."""
username = username or f"agent_{uuid.uuid4().hex[:8]}"
resp = client.post("/agents/register", json={
"username": username,
"description": description,
})
assert resp.status_code == 200, resp.text
data = resp.json()
api_key = data["api_key"]
# Force-claim the agent so it passes verification gates
db.update_user_status(data["user_id"], "claimed")
return {
"data": data,
"api_key": api_key,
"headers": {"Authorization": f"Bearer {api_key}"},
"user_id": data["user_id"],
"username": data["username"],
}
def _create_market(client: TestClient, headers: dict, minutes: int = 30,
title: str = "Will it rain tomorrow?") -> dict:
"""Create a market closing `minutes` from now. Returns JSON body."""
closes_at = (datetime.now(timezone.utc) + timedelta(minutes=minutes)).isoformat()
resp = client.post("/markets", json={
"title": title,
"description": "Test market",
"closes_at": closes_at,
}, headers=headers)
assert resp.status_code == 200, resp.text
return resp.json()
# ---------------------------------------------------------------------------
# Fixtures
# ---------------------------------------------------------------------------
@pytest.fixture(autouse=True)
def reset_storage():
"""Guarantee a clean slate for every test."""
_fresh_storage()
yield
_fresh_storage()
@pytest.fixture()
def client():
return TestClient(app, raise_server_exceptions=False)
# ===================================================================
# 1. Register Agent
# ===================================================================
class TestRegisterAgent:
"""POST /agents/register"""
def test_register_returns_api_key(self, client):
resp = client.post("/agents/register", json={
"username": "testbot",
"description": "A test agent",
})
assert resp.status_code == 200
body = resp.json()
assert body["username"] == "testbot"
assert body["api_key"].startswith("mm_")
assert body["balance"] == STARTING_BALANCE
assert "user_id" in body
def test_register_duplicate_username(self, client):
client.post("/agents/register", json={"username": "dup_agent"})
resp = client.post("/agents/register", json={"username": "dup_agent"})
assert resp.status_code == 400
def test_register_invalid_username(self, client):
resp = client.post("/agents/register", json={"username": "no spaces!"})
assert resp.status_code == 422 # Pydantic validation
# ===================================================================
# 2. Create Market
# ===================================================================
class TestCreateMarket:
"""POST /markets"""
def test_create_market_fields(self, client):
agent = _register_agent(client)
market = _create_market(client, agent["headers"])
assert "id" in market
assert market["title"] == "Will it rain tomorrow?"
assert market["status"] == "OPEN"
assert market["probability"] == pytest.approx(0.5, abs=0.01)
assert market["pool"]["YES"] == pytest.approx(50.0)
assert market["pool"]["NO"] == pytest.approx(50.0)
assert market["creator_id"] == agent["user_id"]
# Creation cost now equals initial_liquidity (default 50), not old flat MARKET_CREATION_COST
assert market["creation_cost"] == pytest.approx(50.0)
def test_create_market_deducts_balance(self, client):
agent = _register_agent(client)
_create_market(client, agent["headers"])
me = client.get("/me", headers=agent["headers"]).json()
# Creation cost = initial_liquidity (default 50), not old flat MARKET_CREATION_COST
default_liquidity = 50.0
assert me["balance"] == pytest.approx(STARTING_BALANCE - default_liquidity, abs=0.01)
def test_create_market_closes_in_past(self, client):
agent = _register_agent(client)
past = (datetime.now(timezone.utc) - timedelta(hours=1)).isoformat()
resp = client.post("/markets", json={
"title": "Already closed",
"closes_at": past,
}, headers=agent["headers"])
assert resp.status_code == 400
def test_create_market_requires_auth(self, client):
closes = (datetime.now(timezone.utc) + timedelta(minutes=30)).isoformat()
resp = client.post("/markets", json={
"title": "No auth market",
"closes_at": closes,
})
assert resp.status_code == 401
# ===================================================================
# 3. Place Bet (YES / NO)
# ===================================================================
class TestPlaceBet:
"""POST /markets/{id}/bet"""
def test_bet_yes_updates_probability(self, client):
creator = _register_agent(client, "creator1")
market = _create_market(client, creator["headers"])
market_id = market["id"]
bettor = _register_agent(client, "bettor1")
resp = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES",
"amount": 50,
}, headers=bettor["headers"])
assert resp.status_code == 200
body = resp.json()
assert body["outcome"] == "YES"
assert body["shares"] > 0
assert body["probability_after"] > body["probability_before"]
assert body["fee"] == pytest.approx(50 * TRADE_FEE_RATE, abs=0.01)
assert body["total_cost"] == pytest.approx(50 + 50 * TRADE_FEE_RATE, abs=0.01)
def test_bet_no_decreases_probability(self, client):
creator = _register_agent(client, "creator2")
market = _create_market(client, creator["headers"])
market_id = market["id"]
bettor = _register_agent(client, "bettor2")
resp = client.post(f"/markets/{market_id}/bet", json={
"outcome": "NO",
"amount": 50,
}, headers=bettor["headers"])
assert resp.status_code == 200
body = resp.json()
assert body["probability_after"] < body["probability_before"]
def test_bet_balance_decreases(self, client):
creator = _register_agent(client, "creator3")
market = _create_market(client, creator["headers"])
bettor = _register_agent(client, "bettor3")
before = client.get("/me", headers=bettor["headers"]).json()["balance"]
resp = client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES",
"amount": 100,
}, headers=bettor["headers"])
body = resp.json()
assert body["new_balance"] == pytest.approx(
before - 100 - 100 * TRADE_FEE_RATE, abs=0.01
)
def test_bet_creator_receives_fee(self, client):
creator = _register_agent(client, "creator4")
market = _create_market(client, creator["headers"])
creator_bal_before = client.get("/me", headers=creator["headers"]).json()["balance"]
bettor = _register_agent(client, "bettor4")
client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES",
"amount": 100,
}, headers=bettor["headers"])
creator_bal_after = client.get("/me", headers=creator["headers"]).json()["balance"]
expected_creator_fee = 100 * TRADE_FEE_RATE * 0.5 # 50% of 2% fee
assert creator_bal_after == pytest.approx(
creator_bal_before + expected_creator_fee, abs=0.01
)
# ===================================================================
# 4. Sell Position
# ===================================================================
class TestSellPosition:
"""POST /markets/{id}/sell"""
def test_sell_returns_funds_minus_fee(self, client):
creator = _register_agent(client, "sell_creator")
market = _create_market(client, creator["headers"])
market_id = market["id"]
trader = _register_agent(client, "sell_trader")
# Buy shares first
buy = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES",
"amount": 50,
}, headers=trader["headers"]).json()
shares_bought = buy["shares"]
# Sell all shares back
resp = client.post(f"/markets/{market_id}/sell", json={
"outcome": "YES",
"shares": shares_bought,
}, headers=trader["headers"])
assert resp.status_code == 200
body = resp.json()
assert body["shares_sold"] == pytest.approx(shares_bought, abs=0.001)
assert body["fee_paid"] > 0
assert body["amount_received"] > 0
# Probability should revert toward 0.5 after selling
assert body["probability_after"] < body["probability_before"]
def test_sell_insufficient_shares(self, client):
creator = _register_agent(client, "sell_creator2")
market = _create_market(client, creator["headers"])
market_id = market["id"]
trader = _register_agent(client, "sell_trader2")
client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES",
"amount": 10,
}, headers=trader["headers"])
resp = client.post(f"/markets/{market_id}/sell", json={
"outcome": "YES",
"shares": 999999,
}, headers=trader["headers"])
assert resp.status_code == 400
def test_sell_no_position(self, client):
creator = _register_agent(client, "sell_creator3")
market = _create_market(client, creator["headers"])
outsider = _register_agent(client, "outsider")
resp = client.post(f"/markets/{market['id']}/sell", json={
"outcome": "YES",
"shares": 1,
}, headers=outsider["headers"])
assert resp.status_code == 400
# ===================================================================
# 5. Resolve Market & Payouts
# ===================================================================
class TestResolveMarket:
"""POST /markets/{id}/resolve — payouts to winners.
Issue #115: resolving an OPEN market with multiple traders now forms
a committee and returns 403 to start the committee vote window.
These tests expire the deadline so the creator can resolve immediately.
"""
def _setup_market_with_bets(self, client):
"""Helper: create a market, place opposing bets, return context."""
creator = _register_agent(client, "res_creator")
market = _create_market(client, creator["headers"])
market_id = market["id"]
yes_bettor = _register_agent(client, "yes_bettor")
no_bettor = _register_agent(client, "no_bettor")
client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 100,
}, headers=yes_bettor["headers"])
client.post(f"/markets/{market_id}/bet", json={
"outcome": "NO", "amount": 100,
}, headers=no_bettor["headers"])
return {
"creator": creator,
"yes_bettor": yes_bettor,
"no_bettor": no_bettor,
"market_id": market_id,
}
def _initiate_and_force_resolve(self, client, market_id, creator_headers, outcome):
"""Initiate resolution (forms committee), expire deadline, then resolve.
Issue #115: resolving an OPEN market with traders first forms a
committee (returns 403). We expire the deadline so the second
resolve call goes through immediately.
"""
resp = client.post(f"/markets/{market_id}/resolve", json={
"outcome": outcome,
}, headers=creator_headers)
if resp.status_code == 403:
# Committee window active — expire it
m = db._markets[market_id]
m["resolution_deadline"] = datetime.now(timezone.utc) - timedelta(minutes=1)
resp = client.post(f"/markets/{market_id}/resolve", json={
"outcome": outcome,
}, headers=creator_headers)
return resp
def test_resolve_yes_pays_yes_holders(self, client):
ctx = self._setup_market_with_bets(client)
yes_bal_before = client.get("/me", headers=ctx["yes_bettor"]["headers"]).json()["balance"]
resp = self._initiate_and_force_resolve(
client, ctx["market_id"], ctx["creator"]["headers"], "YES")
assert resp.status_code == 200
body = resp.json()
assert body["status"] == "RESOLVED"
assert body["resolution"] == "YES"
yes_bal_after = client.get("/me", headers=ctx["yes_bettor"]["headers"]).json()["balance"]
assert yes_bal_after > yes_bal_before, "YES bettor should profit"
def test_resolve_no_pays_no_holders(self, client):
ctx = self._setup_market_with_bets(client)
no_bal_before = client.get("/me", headers=ctx["no_bettor"]["headers"]).json()["balance"]
resp = self._initiate_and_force_resolve(
client, ctx["market_id"], ctx["creator"]["headers"], "NO")
assert resp.status_code == 200
no_bal_after = client.get("/me", headers=ctx["no_bettor"]["headers"]).json()["balance"]
assert no_bal_after > no_bal_before, "NO bettor should profit"
def test_losers_do_not_receive_payout(self, client):
ctx = self._setup_market_with_bets(client)
no_bal_before = client.get("/me", headers=ctx["no_bettor"]["headers"]).json()["balance"]
self._initiate_and_force_resolve(
client, ctx["market_id"], ctx["creator"]["headers"], "YES")
no_bal_after = client.get("/me", headers=ctx["no_bettor"]["headers"]).json()["balance"]
assert no_bal_after == pytest.approx(no_bal_before, abs=0.01), "Loser balance should not change"
def test_resolve_twice_fails(self, client):
ctx = self._setup_market_with_bets(client)
self._initiate_and_force_resolve(
client, ctx["market_id"], ctx["creator"]["headers"], "YES")
resp = client.post(f"/markets/{ctx['market_id']}/resolve", json={
"outcome": "NO",
}, headers=ctx["creator"]["headers"])
assert resp.status_code == 400
def test_only_creator_can_resolve(self, client):
ctx = self._setup_market_with_bets(client)
resp = client.post(f"/markets/{ctx['market_id']}/resolve", json={
"outcome": "YES",
}, headers=ctx["yes_bettor"]["headers"])
assert resp.status_code == 403
# ===================================================================
# 6. Edge Cases
# ===================================================================
class TestEdgeCases:
# --- Bet on non-open market ---
def test_bet_on_resolved_market(self, client):
creator = _register_agent(client, "edge_creator")
market = _create_market(client, creator["headers"])
market_id = market["id"]
# Resolve immediately
client.post(f"/markets/{market_id}/resolve", json={
"outcome": "YES",
}, headers=creator["headers"])
bettor = _register_agent(client, "edge_bettor")
resp = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 10,
}, headers=bettor["headers"])
assert resp.status_code == 400
def test_bet_after_event_end_time(self, client):
"""Market past closes_at is still tradeable (issue #115).
closes_at is display-only ('event end time'). Trading continues
until the creator explicitly resolves the market.
"""
creator = _register_agent(client, "edge_creator2")
market = _create_market(client, creator["headers"], minutes=30)
market_id = market["id"]
# Move closes_at into the past — trading should still work
db._markets[market_id]["closes_at"] = datetime.now(timezone.utc) - timedelta(hours=1)
bettor = _register_agent(client, "edge_bettor2")
resp = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 10,
}, headers=bettor["headers"])
assert resp.status_code == 200, "Trading should work after event end time"
def test_sell_after_event_end_time(self, client):
"""Selling works after closes_at (issue #115)."""
creator = _register_agent(client, "sell_after_close_creator")
market = _create_market(client, creator["headers"])
market_id = market["id"]
trader = _register_agent(client, "sell_after_close_trader")
buy = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 50,
}, headers=trader["headers"]).json()
# Move closes_at into the past
db._markets[market_id]["closes_at"] = datetime.now(timezone.utc) - timedelta(hours=1)
resp = client.post(f"/markets/{market_id}/sell", json={
"outcome": "YES", "shares": buy["shares"],
}, headers=trader["headers"])
assert resp.status_code == 200, "Sell should work after event end time"
def test_only_resolution_stops_trading(self, client):
"""Only resolution stops trading, not closes_at (issue #115)."""
creator = _register_agent(client, "only_res_creator")
market = _create_market(client, creator["headers"])
market_id = market["id"]
bettor = _register_agent(client, "only_res_bettor")
# Move closes_at into the past — trading should still work
db._markets[market_id]["closes_at"] = datetime.now(timezone.utc) - timedelta(hours=1)
resp = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 10,
}, headers=bettor["headers"])
assert resp.status_code == 200
# Now resolve the market
client.post(f"/markets/{market_id}/resolve", json={
"outcome": "YES",
}, headers=creator["headers"])
# Trading should now fail
resp = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 10,
}, headers=bettor["headers"])
assert resp.status_code == 400
# --- Insufficient balance ---
def test_bet_insufficient_balance(self, client):
creator = _register_agent(client, "edge_creator3")
market = _create_market(client, creator["headers"])
poor = _register_agent(client, "poor_agent")
# Drain balance
db._users[poor["user_id"]]["balance"] = 1.0
resp = client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES", "amount": 500,
}, headers=poor["headers"])
assert resp.status_code == 400
assert resp.json().get("error") or resp.json().get("detail")
def test_create_market_insufficient_balance(self, client):
agent = _register_agent(client, "broke_creator")
db._users[agent["user_id"]]["balance"] = 10.0 # Below MIN_CREATION_LIQUIDITY (50)
closes = (datetime.now(timezone.utc) + timedelta(minutes=30)).isoformat()
resp = client.post("/markets", json={
"title": "Can't afford this",
"closes_at": closes,
}, headers=agent["headers"])
assert resp.status_code == 400
# --- Invalid market ID ---
def test_bet_invalid_market_id(self, client):
agent = _register_agent(client, "edge_agent4")
resp = client.post("/markets/not-a-uuid/bet", json={
"outcome": "YES", "amount": 10,
}, headers=agent["headers"])
assert resp.status_code == 400
def test_bet_nonexistent_market(self, client):
agent = _register_agent(client, "edge_agent5")
fake_id = str(uuid.uuid4())
resp = client.post(f"/markets/{fake_id}/bet", json={
"outcome": "YES", "amount": 10,
}, headers=agent["headers"])
assert resp.status_code == 404
def test_get_nonexistent_market(self, client):
fake_id = str(uuid.uuid4())
resp = client.get(f"/markets/{fake_id}")
assert resp.status_code == 404
# --- Sell on non-open market ---
def test_sell_on_resolved_market(self, client):
creator = _register_agent(client, "sell_edge_creator")
market = _create_market(client, creator["headers"])
market_id = market["id"]
trader = _register_agent(client, "sell_edge_trader")
client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 20,
}, headers=trader["headers"])
# Resolve
client.post(f"/markets/{market_id}/resolve", json={
"outcome": "YES",
}, headers=creator["headers"])
resp = client.post(f"/markets/{market_id}/sell", json={
"outcome": "YES", "shares": 1,
}, headers=trader["headers"])
assert resp.status_code == 400
# --- Auth edge cases ---
def test_bet_without_auth(self, client):
creator = _register_agent(client, "noauth_creator")
market = _create_market(client, creator["headers"])
resp = client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES", "amount": 10,
})
assert resp.status_code == 401
def test_bet_with_bad_key(self, client):
creator = _register_agent(client, "badkey_creator")
market = _create_market(client, creator["headers"])
resp = client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES", "amount": 10,
}, headers={"Authorization": "Bearer mm_invalid_key"})
assert resp.status_code == 401
# --- Bet amount edge cases ---
def test_bet_amount_zero(self, client):
creator = _register_agent(client, "zero_creator")
market = _create_market(client, creator["headers"])
bettor = _register_agent(client, "zero_bettor")
resp = client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES", "amount": 0,
}, headers=bettor["headers"])
assert resp.status_code == 422 # Pydantic gt=0
def test_bet_amount_exceeds_max(self, client):
creator = _register_agent(client, "max_creator")
market = _create_market(client, creator["headers"])
bettor = _register_agent(client, "max_bettor")
resp = client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES", "amount": 501,
}, headers=bettor["headers"])
assert resp.status_code == 422 # Pydantic le=500
# ===================================================================
# 7. Read Endpoints (sanity)
# ===================================================================
class TestReadEndpoints:
def test_list_markets(self, client):
creator = _register_agent(client, "list_creator")
_create_market(client, creator["headers"], title="Market A")
# Reset cooldown so second create works
db._users[creator["user_id"]]["last_market_created_at"] = None
_create_market(client, creator["headers"], title="Market B")
resp = client.get("/markets?status=all")
assert resp.status_code == 200
body = resp.json()
# /markets now returns a paginated envelope {data: [...], pagination: {...}}
assert "data" in body
assert "pagination" in body
assert len(body["data"]) >= 2
def test_get_market_detail(self, client):
creator = _register_agent(client, "detail_creator")
market = _create_market(client, creator["headers"])
resp = client.get(f"/markets/{market['id']}")
assert resp.status_code == 200
body = resp.json()
assert body["id"] == market["id"]
assert "pool" in body
assert "probability" in body
def test_market_history(self, client):
creator = _register_agent(client, "hist_creator")
market = _create_market(client, creator["headers"])
bettor = _register_agent(client, "hist_bettor")
client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES", "amount": 20,
}, headers=bettor["headers"])
resp = client.get(f"/markets/{market['id']}/history")
assert resp.status_code == 200
points = resp.json()["points"]
assert len(points) >= 2 # Initial + at least 1 bet
def test_market_positions(self, client):
creator = _register_agent(client, "pos_creator")
market = _create_market(client, creator["headers"])
bettor = _register_agent(client, "pos_bettor")
client.post(f"/markets/{market['id']}/bet", json={
"outcome": "YES", "amount": 30,
}, headers=bettor["headers"])
resp = client.get(f"/markets/{market['id']}/positions")
assert resp.status_code == 200
positions = resp.json()["positions"]
assert len(positions) >= 1
assert positions[0]["yes_shares"] > 0
def test_me_endpoint(self, client):
agent = _register_agent(client, "me_agent")
resp = client.get("/me", headers=agent["headers"])
assert resp.status_code == 200
body = resp.json()
assert body["username"] == "me_agent"
assert body["currency"] == "ŧ"
def test_leaderboard(self, client):
_register_agent(client, "lb_agent")
resp = client.get("/leaderboard")
assert resp.status_code == 200
body = resp.json()
# /leaderboard now returns a paginated envelope {data: [...], pagination: {...}}
assert "data" in body
assert isinstance(body["data"], list)
# ===================================================================
# 8. Liquidity Reclaim (issue #170)
# ===================================================================
class TestLiquidityReclaim:
"""Verify that market creators recover their seed liquidity at resolution.
The creation cost equals initial_liquidity (default 50ŧ). The full
amount seeds the pool and is recoverable via the winning-pool residual
when the market resolves.
Previously, MARKET_CREATION_COST was a flat 100ŧ while the pool was
only seeded with 50ŧ — the 50ŧ gap was silently burned.
"""
def _force_resolve(self, client, market_id, creator_headers, outcome):
"""Initiate resolution and force past committee window if needed."""
resp = client.post(f"/markets/{market_id}/resolve", json={
"outcome": outcome,
}, headers=creator_headers)
if resp.status_code == 403:
m = db._markets[market_id]
m["resolution_deadline"] = datetime.now(timezone.utc) - timedelta(minutes=1)
resp = client.post(f"/markets/{market_id}/resolve", json={
"outcome": outcome,
}, headers=creator_headers)
assert resp.status_code == 200, f"Resolution failed: {resp.text}"
return resp
def test_creation_cost_equals_initial_liquidity(self, client):
"""Creation cost deducted == initial_liquidity (no gap/burn)."""
creator = _register_agent(client, "liq_cost_creator")
bal_before = client.get("/me", headers=creator["headers"]).json()["balance"]
closes = (datetime.now(timezone.utc) + timedelta(minutes=30)).isoformat()
resp = client.post("/markets", json={
"title": "Liquidity cost test",
"closes_at": closes,
"initial_liquidity": 75,
}, headers=creator["headers"])
assert resp.status_code == 200
body = resp.json()
assert body["creation_cost"] == pytest.approx(75.0)
assert body["pool"]["YES"] == pytest.approx(75.0)
assert body["pool"]["NO"] == pytest.approx(75.0)
bal_after = client.get("/me", headers=creator["headers"]).json()["balance"]
assert bal_after == pytest.approx(bal_before - 75.0, abs=0.01)
def test_full_reclaim_no_trades_yes(self, client):
"""Creator recovers full liquidity when market resolves YES with no trades."""
creator = _register_agent(client, "liq_yes_creator")
bal_before_create = client.get("/me", headers=creator["headers"]).json()["balance"]
market = _create_market(client, creator["headers"])
market_id = market["id"]
liquidity = market["creation_cost"]
bal_after_create = client.get("/me", headers=creator["headers"]).json()["balance"]
assert bal_after_create == pytest.approx(bal_before_create - liquidity, abs=0.01)
self._force_resolve(client, market_id, creator["headers"], "YES")
bal_after_resolve = client.get("/me", headers=creator["headers"]).json()["balance"]
# Creator should get full liquidity back — net cost ≈ 0
assert bal_after_resolve == pytest.approx(bal_before_create, abs=0.01), (
f"Creator should recover full liquidity. Before: {bal_before_create}, "
f"After: {bal_after_resolve}, Liquidity: {liquidity}"
)
def test_full_reclaim_no_trades_no(self, client):
"""Creator recovers full liquidity when market resolves NO with no trades."""
creator = _register_agent(client, "liq_no_creator")
bal_before = client.get("/me", headers=creator["headers"]).json()["balance"]
market = _create_market(client, creator["headers"])
market_id = market["id"]
self._force_resolve(client, market_id, creator["headers"], "NO")
bal_after = client.get("/me", headers=creator["headers"]).json()["balance"]
assert bal_after == pytest.approx(bal_before, abs=0.01), (
"Creator should recover full liquidity on NO resolution too"
)
def test_custom_liquidity_reclaim(self, client):
"""Creator specifying higher liquidity recovers it fully."""
creator = _register_agent(client, "liq_custom_creator")
bal_before = client.get("/me", headers=creator["headers"]).json()["balance"]
closes = (datetime.now(timezone.utc) + timedelta(minutes=30)).isoformat()
resp = client.post("/markets", json={
"title": "Custom liquidity test",
"closes_at": closes,
"initial_liquidity": 200,
}, headers=creator["headers"])
assert resp.status_code == 200
market = resp.json()
market_id = market["id"]
assert market["pool"]["YES"] == pytest.approx(200.0)
assert market["creation_cost"] == pytest.approx(200.0)
bal_after_create = client.get("/me", headers=creator["headers"]).json()["balance"]
assert bal_after_create == pytest.approx(bal_before - 200.0, abs=0.01)
self._force_resolve(client, market_id, creator["headers"], "YES")
bal_after_resolve = client.get("/me", headers=creator["headers"]).json()["balance"]
assert bal_after_resolve == pytest.approx(bal_before, abs=0.01)
def test_zero_sum_with_trading(self, client):
"""Total payouts == total money in (zero-sum accounting)."""
creator = _register_agent(client, "zs_creator")
bettor = _register_agent(client, "zs_bettor")
creator_bal_start = client.get("/me", headers=creator["headers"]).json()["balance"]
bettor_bal_start = client.get("/me", headers=bettor["headers"]).json()["balance"]
market = _create_market(client, creator["headers"])
market_id = market["id"]
# Place a YES bet
resp = client.post(f"/markets/{market_id}/bet", json={
"outcome": "YES", "amount": 50,
}, headers=bettor["headers"])
assert resp.status_code == 200
bet_fee = resp.json()["fee"]
self._force_resolve(client, market_id, creator["headers"], "YES")
creator_bal_end = client.get("/me", headers=creator["headers"]).json()["balance"]
bettor_bal_end = client.get("/me", headers=bettor["headers"]).json()["balance"]
# Total money in = liquidity + bet_amount + bet_fee
# Total money out = creator_payout + bettor_payout + creator_trading_fee
# These should balance (zero-sum modulo platform fee)
total_change = (creator_bal_end - creator_bal_start) + (bettor_bal_end - bettor_bal_start)
# The only "leak" is the platform's share of trading fees
platform_fee = bet_fee * 0.5 # platform gets 50% of trading fee
assert total_change == pytest.approx(-platform_fee, abs=0.1), (
f"Economy should be zero-sum (minus platform fee). "
f"Creator Δ={creator_bal_end - creator_bal_start:.2f}, "
f"Bettor Δ={bettor_bal_end - bettor_bal_start:.2f}, "
f"Platform fee={platform_fee:.2f}"
)
def test_min_liquidity_enforced(self, client):
"""Cannot create a market with liquidity below MIN_CREATION_LIQUIDITY."""
agent = _register_agent(client, "liq_min_agent")
closes = (datetime.now(timezone.utc) + timedelta(minutes=30)).isoformat()
resp = client.post("/markets", json={
"title": "Too cheap market",
"closes_at": closes,
"initial_liquidity": 10, # Below minimum of 50
}, headers=agent["headers"])
assert resp.status_code == 422 # Pydantic validation: ge=50
# ===================================================================
# Run
# ===================================================================
if __name__ == "__main__":
pytest.main([__file__, "-v"])