Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up constructors #5030

Open
gf712 opened this issue May 14, 2020 · 6 comments
Open

Clean up constructors #5030

gf712 opened this issue May 14, 2020 · 6 comments

Comments

@gf712
Copy link
Member

gf712 commented May 14, 2020

Throughout shogun we have various constructors with lots of repetitions, e.g. calls to register_params. We could avoid using register_params by using delegating constructors and then only have a single constructor responsible for parameter registration. This would avoid bugs with initialization, which lead to undefined behaviour, and parameter registration.

@karlnapf
Copy link
Member

++
Could you maybe post an example PR where this is done, then people have an easier time reproducing it

@gf712
Copy link
Member Author

gf712 commented May 14, 2020

Sure, I'll start a PR where I pick a class and clean up the constructors and tag it here

@jonpsy
Copy link
Contributor

jonpsy commented May 15, 2020

I think I can give this a shot ;D

@ellikamishra
Copy link

I can try this!

@GuoxinYin
Copy link
Contributor

Hello, is anyone working on this right now? If no, I can work on this!

gf712 pushed a commit that referenced this issue Dec 8, 2020
* Kernel Constructor Cleanup #5030
@ArhamaQ
Copy link

ArhamaQ commented Sep 19, 2023

hey, I am a beginner but have strong C++ knowledge. I think I can resolve this issue. if it is still open. can you assign me this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants