-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up constructors #5030
Comments
++ |
Sure, I'll start a PR where I pick a class and clean up the constructors and tag it here |
I think I can give this a shot ;D |
I can try this! |
Hello, is anyone working on this right now? If no, I can work on this! |
hey, I am a beginner but have strong C++ knowledge. I think I can resolve this issue. if it is still open. can you assign me this issue? |
Throughout shogun we have various constructors with lots of repetitions, e.g. calls to
register_params
. We could avoid usingregister_params
by using delegating constructors and then only have a single constructor responsible for parameter registration. This would avoid bugs with initialization, which lead to undefined behaviour, and parameter registration.The text was updated successfully, but these errors were encountered: