You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are working on a legacy application with a large number of editors and are noticing a severe performance impact of the floating menu. Looking at the ngx-editor source code I think the problem is the @HostListener decorator, which is known to cause extra change detection cycles - In our case: clicking anywhere on the page triggers almost 200 change detection cycles, resulting in a completely unresponsive app.
According to https://dev.to/angular/ain-t-nobody-needs-hostlistener-fg4 an alternative solution is to acces the underlying events directly and managing them using rxjs. I don't quite understand the suggested rxjs magic yet and have not been able to verify the solution, but overall it seems not too hard to implement. Is there any chance you might take a look at it?
PS: A fix for Angular 14 would be very highly appreciated. Stakeholders are pushing new features and are currently not giving us enough time to upgrade this beast of an app with its many dependencies.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi,
We are working on a legacy application with a large number of editors and are noticing a severe performance impact of the floating menu. Looking at the ngx-editor source code I think the problem is the
@HostListener
decorator, which is known to cause extra change detection cycles - In our case: clicking anywhere on the page triggers almost 200 change detection cycles, resulting in a completely unresponsive app.According to https://dev.to/angular/ain-t-nobody-needs-hostlistener-fg4 an alternative solution is to acces the underlying events directly and managing them using rxjs. I don't quite understand the suggested rxjs magic yet and have not been able to verify the solution, but overall it seems not too hard to implement. Is there any chance you might take a look at it?
PS: A fix for Angular 14 would be very highly appreciated. Stakeholders are pushing new features and are currently not giving us enough time to upgrade this beast of an app with its many dependencies.
Beta Was this translation helpful? Give feedback.
All reactions