Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: default icon configuration invalid #538

Open
swurzinger opened this issue Apr 25, 2024 · 1 comment
Open

[Bug]: default icon configuration invalid #538

swurzinger opened this issue Apr 25, 2024 · 1 comment

Comments

@swurzinger
Copy link

swurzinger commented Apr 25, 2024

What happened?

The default icon configuration, which gets active when you call NgxEditorModule.forRoot() (without arguments) is invalid and causes no icons to show up in the editor.

The issue is that it uses the <path>...< /> definitions in icons directly instead of using Icon.get(), which wraps the SVG path accordingly in an <svg>... < /> element.

Version

v17.0.2

Angular Version

v17

What browsers are you seeing the problem on?

all

Willing to submit a PR?

Yes

@sibiraj-s
Copy link
Owner

Sorry for the delay in response. Can you elaborate the issue a bit more? Also, feel free to raise a PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants