Merge pull request #1549 from creative-commoners/pulls/2.4/campaign-admin-depr

API Update deprecations

Author: GuySartorelli

code/Controller/AssetAdmin.php

@@ -1195,11 +1195,14 @@ public function generateThumbnails(File $file, $thumbnailLinks = false)
     /**
      * Action handler for adding pages to a campaign
      *
-     * @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
+     * @deprecated 2.4.0 Will moved to SilverStripe\CampaignAdmin\Extensions\AddToCampaignExtension
      */
     public function addtocampaign(array $data, Form $form): HTTPResponse
     {
-        Deprecation::noticeWithNoReplacment('2.4.0');
+        Deprecation::noticeWithNoReplacment(
+            '2.4.0',
+            'Will moved to SilverStripe\CampaignAdmin\Extensions\AddToCampaignExtension'
+        );
         $id = $data['ID'];
         $record = File::get()->byID($id);
 
@@ -1221,11 +1224,14 @@ public function addtocampaign(array $data, Form $form): HTTPResponse
      *
      * @param HTTPRequest $request
      * @return Form
-     * @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
+     * @deprecated 2.4.0 Will moved to SilverStripe\CampaignAdmin\Extensions\AddToCampaignExtension
      */
     public function addToCampaignForm($request)
     {
-        Deprecation::noticeWithNoReplacment('2.4.0');
+        Deprecation::noticeWithNoReplacment(
+            '2.4.0',
+            'Will moved to SilverStripe\CampaignAdmin\Extensions\AddToCampaignExtension'
+        );
         // Get ID either from posted back value, or url parameter
         $id = $request->param('ID') ?: $request->postVar('ID');
         return $this->getAddToCampaignForm($id);
@@ -1234,11 +1240,14 @@ public function addToCampaignForm($request)
     /**
      * @param int $id
      * @return Form|HTTPResponse
-     * @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
+     * @deprecated 2.4.0 Will moved to SilverStripe\CampaignAdmin\Extensions\AddToCampaignExtension
      */
     public function getAddToCampaignForm($id)
     {
-        Deprecation::noticeWithNoReplacment('2.4.0');
+        Deprecation::noticeWithNoReplacment(
+            '2.4.0',
+            'Will moved to SilverStripe\CampaignAdmin\Extensions\AddToCampaignExtension'
+        );
         // Get record-specific fields
         $record = File::get()->byID($id);
 

code/Extensions/CampaignAdminExtension.php

@@ -14,13 +14,17 @@
  * This extension will only be applied if the `campaign-admin` module is installed.
  *
  * @extends Extension<FileFormFactory>
- * @deprecated 2.4.0 Will be removed without equivalent functionality to replace it
+ * @deprecated 2.4.0 Will be replaced by SilverStripe\CampaignAdmin\Extensions\FileFormFactoryExtension
  */
 class CampaignAdminExtension extends Extension
 {
     public function __construct()
     {
-        Deprecation::noticeWithNoReplacment('2.4.0', scope: Deprecation::SCOPE_CLASS);
+        Deprecation::noticeWithNoReplacment(
+            '2.4.0',
+            'Will be replaced by SilverStripe\CampaignAdmin\Extensions\FileFormFactoryExtension',
+            Deprecation::SCOPE_CLASS
+        );
         parent::__construct();
     }