Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace react-selectable dependency with something maintained #1528

Open
1 task
GuySartorelli opened this issue Dec 18, 2024 · 0 comments
Open
1 task

Replace react-selectable dependency with something maintained #1528

GuySartorelli opened this issue Dec 18, 2024 · 0 comments
Assignees
@emteknetnz
Labels
affects/v6
Milestone
Silverstripe CMS 6.0

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 18, 2024 •
edited by emteknetnz
Loading

react-selectable looks like it may have been made specifically for asset-admin but is no longer being maintained.
It also has some strange coupling - e.g. see https://github.com/unclecheese/react-selectable/blob/802b1ec9ad1ef97fd241f48e612dd1b334b447b8/src/selectable-group.js#L126-L127

I recommend we replace it with https://www.npmjs.com/package/@air/react-drag-to-select

Acceptance Criteria

  • react-selectable is replaced with a maintained alternative

PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
affects/v6
Projects
None yet
Milestone
Silverstripe CMS 6.0
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli