Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UploadField component for Pattern Library with visual changes #746

Open
chillu opened this issue Mar 12, 2018 · 1 comment
Open

UploadField component for Pattern Library with visual changes #746

chillu opened this issue Mar 12, 2018 · 1 comment

Comments

@chillu
Copy link
Member

chillu commented Mar 12, 2018

Acceptance Criteria

  • As a frontend dev and UX designer, I can use the pattern library as a complete reference for visual and behaviour variations of UploadField
  • The visual representation of the component is as specified in the designs

Design reference

https://projects.invisionapp.com/dsm/silver-stripe/silver-stripe/asset/components/5b5e6e3984472000117f3ee4

@clarkepaul
Copy link
Contributor

clarkepaul commented Sep 4, 2019

This issue has been extended to cover some of the main differences between the UploadField designs and the component as it stands in the Pattern Library (it doesn't exist as yet). There are a number of other issues which touch on different aspects of these design changes already.

Refer to designs https://projects.invisionapp.com/dsm/silver-stripe/silver-stripe/asset/components/5b5e6e3984472000117f3ee4

Functionality differences opened as separate issues:

Design differences covered by this issue:

  • Reorder insert links to suggest inserting from Files rather than uploading from your computer (includes text changes).
  • Loading indicator doesn't match the designs and is in the wrong place
  • View (eye) icon should be removed (the whole field should be clickable like a button). The whole component should also have the correct default, hover and focus states.
  • Height of component is out by 10px (the drop zone and field after a file has been attached should be the same size – avoid the page jumping and provides a smooth transition).
  • Border colours are not consistent with designs
  • State badges should not have backgrounds behind them and are the wrong colours
  • Stats are back to front should be e.g 186KB, PNG

@sachajudd sachajudd removed their assignment Sep 17, 2019
@clarkepaul clarkepaul changed the title Pattern Library for UploadField UploadField component for Pattern Library with visual changes Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants