fix & run rustfmt, fix clippy warnings, fix examples, remove travis.yml & ci for wasm32 check

Author: elpiel

.github/workflows/ci.yml

@@ -43,7 +43,7 @@ jobs:
           profile: minimal
           toolchain: stable
           override: true
-      - run: rustup component add rustfmt
+          components: rustfmt
       - uses: actions-rs/cargo@v1
         with:
           command: fmt
@@ -59,8 +59,23 @@ jobs:
           profile: minimal
           toolchain: stable
           override: true
-      - run: rustup component add clippy
+          components: clippy
       - uses: actions-rs/cargo@v1
         with:
           command: clippy
-          args: -- -D warnings
+          args: --all-features -- -D warnings
+  wasm32:
+    name: Wasm32 check
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          target: wasm32-unknown-unknown
+          toolchain: stable
+          override: true
+      - uses: actions-rs/cargo@v1
+        with:
+          command: check
+          args: --all-features --benches --bins --examples --tests

.gitignore

@@ -1,13 +1,13 @@
 dist
-crate/bin
-crate/pkg
-crate/target
-crate/wasm-pack.log
-crate/Cargo.lock
+bin
+pkg
+target
+wasm-pack.log
+Cargo.lock
 webpack_demo/node_modules
 webpack_demo/dist
 webpack_demo/package-lock.json
 react_app_demo/node_modules
 photon-docs/site
 output*.jpg
-output*.png
+output*.png

crate/.rustfmt.toml .rustfmt.toml

@@ -112,6 +112,15 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
 ##### See More Examples
 [For more examples, check out the guide on how to get started with Photon natively.](https://silvia-odwyer.github.io/photon/guide/using-photon-natively/)
 
+### Building WebAssembly package
+
+In order to build the WebAssembly package you will need `wasm-pack`. Check https://rustwasm.github.io/wasm-pack/installer/ on how to install it. Then you can run the command:
+
+
+```bash
+wasm-pack build ./crate
+```
+
 ## Get Started With WebAssembly
 ### Using a Bundler?
 #### Installing Photon
@@ -155,7 +164,6 @@ git clone https://github.com/silvia-odwyer/photon
 
 Run the binary, which will perform an image processing function on an image:
 ```sh
-cd crate
 cargo run --release
 ```
 

README.md

@@ -1,15 +1,8 @@
-use criterion::{black_box, criterion_group, criterion_main, BenchmarkId, Criterion};
-use photon_rs::channels::alter_red_channel;
-use photon_rs::conv::gaussian_blur;
+use criterion::{criterion_group, criterion_main, Criterion};
 use photon_rs::native::{open_image, save_image};
 use photon_rs::transform::{resize, SamplingFilter};
-use photon_rs::PhotonImage;
 use std::time::Duration;
 
-fn gaussian_blur_3x3(img: &mut PhotonImage) {
-    gaussian_blur(img, 3);
-}
-
 fn criterion_benchmark(c: &mut Criterion) {
     c.bench_function("invert_image", |b| b.iter(|| invert_image()));
 
@@ -20,7 +13,8 @@ fn criterion_benchmark(c: &mut Criterion) {
 
 fn invert_image() {
     // Open the image (a PhotonImage is returned)
-    let mut img = open_image("examples/input_images/underground.jpg").expect("File should open");
+    let mut img =
+        open_image("examples/input_images/underground.jpg").expect("File should open");
 
     // Invert the image
     photon_rs::channels::invert(&mut img);
@@ -32,7 +26,8 @@ fn invert_image() {
 }
 
 fn resize_png() {
-    let mut img = open_image("examples/input_images/underground.png").expect("File should open");
+    let mut img =
+        open_image("examples/input_images/underground.png").expect("File should open");
 
     let resized_img = resize(&mut img, 800, 600, SamplingFilter::Lanczos3);
 
@@ -43,7 +38,8 @@ fn resize_png() {
 
 fn resize_jpg() {
     // Open the image (a PhotonImage is returned)
-    let mut img = open_image("examples/input_images/underground.jpg").expect("File should open");
+    let mut img =
+        open_image("examples/input_images/underground.jpg").expect("File should open");
 
     let resized_img = resize(&mut img, 800, 600, SamplingFilter::Lanczos3);
 

crate/.travis.yml

@@ -1,8 +1,8 @@
 ## Examples
 Examples for running Photon natively.
 
-Note: If you're here to see WebAssembly in action, this is the wrong path, turn back. 
-To see WebAssembly in action, clone this repo and run `npm start` after `cd`ing into photon. 
+Note: If you're here to see WebAssembly in action, this is the wrong path, turn back.
+To see WebAssembly in action, clone this repo and run `npm start` after `cd`ing into photon.
 More details can be found in the main repo README.
 
 ### Running These Examples
@@ -14,8 +14,7 @@ git clone https://github.com/silvia-odwyer/photon
 Several examples are included, for this demo, we'll run the Rust file called `example.rs`:
 
 ```sh
-cd crate
-cargo run --example example --release 
+cargo run --example example --release
 ```
 
 Make sure the `--release` flag is added.
@@ -28,5 +27,5 @@ To change the images being inputted, add your image to `input_images` and change
 To run the example which adds text to an image:
 
 ```sh
-cargo run --example add_text 
-```
+cargo run --example add_text
+```

crate/benches/photon_benchmark.rs

@@ -7,7 +7,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     // Replace the variable file_name with whatever image you would like to apply filters to
     // Ensure it is in the example_output directory, which can be found one sub-dir inside the photon dir.
     // However the image referenced below, along with sample images, have been included in the dir.
-    let file_name = "examples/input_images/daisies_fuji.jpg";
+    let file_name = "crate/examples/input_images/daisies_fuji.jpg";
 
     // Open the image
     let mut img = photon::native::open_image(file_name)?;

crate/examples/README.md

@@ -7,7 +7,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     // Replace the variable file_name with whatever image you would like to apply filters to
     // Ensure it is in the example_output directory, which can be found one sub-dir inside the photon dir.
     // However the image referenced below, along with sample images, have been included in the dir.
-    let file_name = "examples/input_images/underground.jpg";
+    let file_name = "crate/examples/input_images/underground.jpg";
 
     // Open the image
     let effects: [&str; 5] =
@@ -21,10 +21,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         photon::colour_spaces::hsl(&mut img, effect, 0.2_f32);
 
         // Write the contents of this image in JPG format.
-        photon::native::save_image(
-            img,
-            &format!("output_{}.jpg", effect)[..],
-        )?;
+        photon::native::save_image(img, &format!("output_{}.jpg", effect)[..])?;
 
         let end = Instant::now();
         println!(

crate/examples/add_text.rs

@@ -3,7 +3,7 @@ extern crate photon_rs;
 extern crate time;
 
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    let file_name = "examples/input_images/daisies_fuji.jpg";
+    let file_name = "crate/examples/input_images/daisies_fuji.jpg";
     println!("file name = {}", file_name);
 
     // // Open the image

crate/examples/example.rs

@@ -9,9 +9,9 @@ use crate::helpers;
 use crate::{PhotonImage, Rgb};
 extern crate palette;
 use crate::channels::palette::Hue;
+use crate::iter::ImageIterator;
 use palette::{Lab, Lch, Pixel, Saturate, Shade, Srgb, Srgba};
 use wasm_bindgen::prelude::*;
-use crate::iter::ImageIterator;
 
 /// Alter a select channel by incrementing or decrementing its value by a constant.
 ///

crate/examples/seam_carver.rs

@@ -6,8 +6,8 @@ use crate::{helpers, PhotonImage, Rgb};
 use image::GenericImageView;
 use palette::{Hsl, Hsv, Hue, Lch, Pixel, Saturate, Shade, Srgba};
 extern crate wasm_bindgen;
-use wasm_bindgen::prelude::*;
 use crate::iter::ImageIterator;
+use wasm_bindgen::prelude::*;
 
 /// Apply gamma correction.
 // #[wasm_bindgen]