Fix analysis warnings in Dart 2.14

Author: simolus3

example/contracts.dart

@@ -58,7 +58,7 @@ Future<void> main() async {
   final client = Web3Client(rpcUrl, Client(), socketConnector: () {
     return IOWebSocketChannel.connect(wsUrl).cast<String>();
   });
-  final credentials = await client.credentialsFromPrivateKey(privateKey);
+  final credentials = EthPrivateKey.fromHex(privateKey);
   final ownAddress = await credentials.extractAddress();
 
   // read the contract abi and tell web3dart where it's deployed (contractAddr)

example/main.dart

@@ -9,7 +9,7 @@ Future<void> main() async {
   // start a client we can use to send transactions
   final client = Web3Client(rpcUrl, Client());
 
-  final credentials = await client.credentialsFromPrivateKey(privateKey);
+  final credentials = EthPrivateKey.fromHex(privateKey);
   final address = credentials.address;
 
   print(address.hexEip55);

lib/src/builder/generator.dart

@@ -1,9 +1,9 @@
 import 'dart:async';
 import 'dart:convert';
 
+import 'package:build/build.dart';
 import 'package:built_collection/built_collection.dart';
 import 'package:code_builder/code_builder.dart';
-import 'package:build/build.dart';
 import 'package:dart_style/dart_style.dart';
 import 'package:path/path.dart';
 import 'package:web3dart/contracts.dart';

lib/src/contracts/abi/arrays.dart

@@ -37,7 +37,9 @@ class FixedBytes extends AbiType<Uint8List> {
         'Invalid length: Tried to encode ${data.length} bytes, but expected exactly $length');
     final paddingBytes = calculatePadLength(length);
 
-    buffer..add(data)..add(Uint8List(paddingBytes));
+    buffer
+      ..add(data)
+      ..add(Uint8List(paddingBytes));
   }
 
   @override
@@ -87,7 +89,9 @@ class DynamicBytes extends AbiType<Uint8List> {
 
     final padding = calculatePadLength(data.length, allowEmpty: true);
 
-    buffer..add(data)..add(Uint8List(padding));
+    buffer
+      ..add(data)
+      ..add(Uint8List(padding));
   }
 
   @override

lib/src/contracts/abi/integers.dart

@@ -107,7 +107,9 @@ class AddressType extends AbiType<EthereumAddress> {
 
   @override
   void encode(EthereumAddress data, LengthTrackingByteSink buffer) {
-    buffer..add(Uint8List(_paddingLen))..add(data.addressBytes);
+    buffer
+      ..add(Uint8List(_paddingLen))
+      ..add(data.addressBytes);
   }
 
   @override

lib/src/core/client.dart

@@ -72,9 +72,7 @@ class Web3Client {
 
     final socket = socketConnector!();
     _streamRpcPeer = rpc.Peer(socket)
-      ..registerMethod('eth_subscription', (rpc.Parameters params) {
-        _filters.handlePubSubNotification(params);
-      });
+      ..registerMethod('eth_subscription', _filters.handlePubSubNotification);
 
     _streamRpcPeer?.listen().then((_) {
       // .listen() will complete when the socket is closed, so reset client

lib/src/core/transaction_signer.dart

@@ -100,10 +100,15 @@ List<dynamic> _encodeToRlp(Transaction transaction, MsgSignature? signature) {
     list.add('');
   }
 
-  list..add(transaction.value?.getInWei)..add(transaction.data);
+  list
+    ..add(transaction.value?.getInWei)
+    ..add(transaction.data);
 
   if (signature != null) {
-    list..add(signature.v)..add(signature.r)..add(signature.s);
+    list
+      ..add(signature.v)
+      ..add(signature.r)
+      ..add(signature.s);
   }
 
   return list;

lib/src/credentials/wallet.dart

@@ -7,17 +7,16 @@ import 'package:pointycastle/api.dart';
 import 'package:pointycastle/block/aes_fast.dart';
 import 'package:pointycastle/digests/sha256.dart';
 import 'package:pointycastle/key_derivators/api.dart';
-import 'package:pointycastle/macs/hmac.dart';
 import 'package:pointycastle/key_derivators/pbkdf2.dart' as pbkdf2;
 import 'package:pointycastle/key_derivators/scrypt.dart' as scrypt;
+import 'package:pointycastle/macs/hmac.dart';
 import 'package:pointycastle/stream/ctr.dart';
 
 import '../crypto/formatting.dart';
 import '../crypto/keccak.dart';
 import '../crypto/random_bridge.dart';
 import '../utils/typed_data.dart';
 import '../utils/uuid.dart';
-
 import 'credentials.dart';
 
 abstract class _KeyDerivator {

test/contracts/abi/event_test.dart

@@ -1,7 +1,7 @@
 import 'package:test/test.dart';
-import 'package:web3dart/crypto.dart';
-import 'package:web3dart/credentials.dart';
 import 'package:web3dart/contracts.dart';
+import 'package:web3dart/credentials.dart';
+import 'package:web3dart/crypto.dart';
 
 void main() {
   final event = ContractEvent(false, 'Transfer', const [

test/core/sign_transaction_test.dart

@@ -1,7 +1,7 @@
-import 'package:web3dart/web3dart.dart';
-import 'package:web3dart/crypto.dart';
 import 'package:http/http.dart';
 import 'package:test/test.dart';
+import 'package:web3dart/crypto.dart';
+import 'package:web3dart/web3dart.dart';
 
 void main() {
   test('signs transactions', () async {

test/credentials/address_test.dart

@@ -1,5 +1,5 @@
-import 'package:web3dart/credentials.dart';
 import 'package:test/test.dart';
+import 'package:web3dart/credentials.dart';
 
 // https://eips.ethereum.org/EIPS/eip-55#test-cases
 const _lowerCaseToEip55 = {

test/credentials/private_key_test.dart

@@ -1,8 +1,8 @@
 import 'dart:convert';
 
+import 'package:test/test.dart';
 import 'package:web3dart/credentials.dart';
 import 'package:web3dart/crypto.dart';
-import 'package:test/test.dart';
 
 void main() {
   test('signs messages', () async {

test/credentials/public_key_test.dart

@@ -1,5 +1,5 @@
-import 'package:web3dart/crypto.dart';
 import 'package:test/test.dart';
+import 'package:web3dart/crypto.dart';
 
 final pubKeys = {
   '038e5d1fccb6b800b4e0fde5080a8c3628a302c4767e7687bea79ba24c6ac268e2':

test/utils/rlp_test.dart

@@ -1,7 +1,8 @@
 import 'dart:convert';
+
+import 'package:test/test.dart';
 import 'package:web3dart/crypto.dart';
 import 'package:web3dart/src/utils/rlp.dart';
-import 'package:test/test.dart';
 
 import 'rlp_test_vectors.dart' as data;