Skip to content

Commit 923b21f

Browse files
authored
Merge pull request #36 from simple-repository/fix/node-deps
Fix npm dependencies
2 parents df64ffb + d22a84b commit 923b21f

File tree

10 files changed

+4401
-6765
lines changed

10 files changed

+4401
-6765
lines changed

.github/workflows/python-publish.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@ jobs:
2424

2525
- uses: actions/setup-node@v4
2626
with:
27-
node-version: 12
27+
node-version: 24
2828

29-
# Install an older Python (needed for the javascript build to succeed)
29+
# Install an older Python (needed for the javascript/scss build to succeed)
3030
- name: Set up temporary Python 3.9
3131
uses: actions/setup-python@v3
3232
with:
3333
python-version: 3.9
3434

3535
- name: Build JS assets
3636
run: |
37-
cd javascript
37+
cd web
3838
npm install --include=dev
3939
npm run build
4040

.github/workflows/python-test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ jobs:
2323

2424
- uses: actions/setup-node@v4
2525
with:
26-
node-version: 12
26+
node-version: 24
2727

28-
# Install an older Python (needed for the javascript build to succeed)
28+
# Install an older Python (needed for the javascript/scss build to succeed)
2929
- name: Set up temporary Python 3.9
3030
uses: actions/setup-python@v3
3131
with:
3232
python-version: 3.9
3333

3434
- name: Build JS assets
3535
run: |
36-
cd javascript
36+
cd web
3737
npm install --include=dev
3838
npm run build
3939

MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# Ensure the sdist doesn't get unnecessary build files.
2-
recursive-exclude javascript *
2+
recursive-exclude web *
33
recursive-exclude screenshots *
44
recursive-exclude .github *

README.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,18 @@ versions. There is currently no intelligent cache invalidation for those cases.
5959

6060
## Development
6161

62-
In order to build the ``simple-repository-browser``, first:
62+
In order to build the ``simple-repository-browser`` you will need access to npm. If not available on the development host,
63+
you can do it in a docker container first:
6364

6465
```bash
65-
cd javascript
66+
docker run --rm -v $PWD:/workdir -it node bash
67+
cd /workdir
68+
```
69+
70+
Bundle the web app:
71+
72+
```bash
73+
cd web
6674
npm install --include=dev
6775
npm run build
6876
cd ..

0 commit comments

Comments
 (0)