Skip to content

Commit 29790ff

Browse files
committed
[Mage] Adjust FFE triggers
1 parent 9dbf2fa commit 29790ff

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

engine/class_modules/sc_mage.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1440,6 +1440,7 @@ struct mage_spell_t : public spell_t
14401440
{
14411441
bool clearcasting = false;
14421442
bool from_the_ashes = false;
1443+
bool frostfire_empowerment = false;
14431444
bool ignite = false;
14441445
bool molten_chill_ignite = false;
14451446
bool touch_of_the_magi = true;
@@ -1726,8 +1727,7 @@ struct mage_spell_t : public spell_t
17261727
}
17271728
}
17281729

1729-
// TODO: Check if the trigger condition is accurate
1730-
if ( !background && school == SCHOOL_FROSTFIRE && rng().roll( p()->talents.frostfire_empowerment->effectN( 3 ).percent() ) )
1730+
if ( triggers.frostfire_empowerment && rng().roll( p()->talents.frostfire_empowerment->effectN( 3 ).percent() ) )
17311731
make_event( *sim, [ this ] { p()->buffs.frostfire_empowerment->trigger(); } );
17321732
}
17331733

@@ -3332,7 +3332,7 @@ struct fireball_t final : public fire_mage_spell_t
33323332
enable_calculate_on_impact( 468655 );
33333333
affected_by.overflowing_energy = true;
33343334
triggers.hot_streak = TT_ALL_TARGETS;
3335-
triggers.ignite = triggers.from_the_ashes = true;
3335+
triggers.ignite = triggers.from_the_ashes = triggers.frostfire_empowerment = true;
33363336

33373337
if ( p->talents.master_of_flame.ok() )
33383338
master_of_flame_mult *= 1.0 + p->find_spell( 1217750 )->effectN( 1 ).percent();
@@ -3540,6 +3540,7 @@ struct flurry_t final : public frost_mage_spell_t
35403540
{
35413541
parse_options( options_str );
35423542
may_miss = false;
3543+
triggers.frostfire_empowerment = true; // Doesn't seem to need Heat Sink
35433544

35443545
add_child( flurry_bolt );
35453546
if ( p->action.glacial_assault )
@@ -3584,6 +3585,7 @@ struct frostbolt_t final : public frost_mage_spell_t
35843585
parse_options( options_str );
35853586
enable_calculate_on_impact( frostfire ? 468655 : 228597 );
35863587
affected_by.overflowing_energy = true;
3588+
triggers.frostfire_empowerment = true;
35873589

35883590
fof_chance = p->talents.fingers_of_frost->effectN( 1 ).percent();
35893591
bf_chance = p->talents.brain_freeze->effectN( 1 ).percent();
@@ -4005,7 +4007,7 @@ struct fire_blast_t final : public fire_mage_spell_t
40054007
{
40064008
parse_options( options_str );
40074009
triggers.hot_streak = TT_ALL_TARGETS;
4008-
triggers.ignite = triggers.from_the_ashes = true;
4010+
triggers.ignite = triggers.from_the_ashes = triggers.frostfire_empowerment = true;
40094011

40104012
if ( p->talents.fire_blast.ok() )
40114013
{

0 commit comments

Comments
 (0)