Fix CI lint and type-check failures

Author: skilledwolf

src/quantumhall_matrixelements/__init__.py

@@ -26,14 +26,14 @@
 from ._select import DEFAULT_CANONICAL_SELECT_MAX_ENTRIES
 from .diagnostic import get_exchange_kernels_opposite_field, get_form_factors_opposite_field
 from .exchange_hankel import get_exchange_kernels_hankel
-from .exchange_ogata import get_exchange_kernels_Ogata
-from .fock import build_fockmatrix_apply, get_fockmatrix_constructor, get_fockmatrix_constructor_hf
 from .exchange_laguerre import (
     ExchangeFockPrecompute,
     QuadratureParams,
     build_exchange_fock_precompute,
     get_exchange_kernels_laguerre,
 )
+from .exchange_ogata import get_exchange_kernels_Ogata
+from .fock import build_fockmatrix_apply, get_fockmatrix_constructor, get_fockmatrix_constructor_hf
 from .planewave import get_form_factors
 
 ComplexArray = NDArray[np.complex128]

src/quantumhall_matrixelements/exchange_hankel.py

@@ -459,7 +459,7 @@ def _get_L(
     if sign_magneticfield == 1:
         phase1 = 1 - 2 * ((sel_n1 - sel_m1) & 1)
         phase2 = 1 - 2 * ((sel_n2 - sel_m2) & 1)
-        Xs = cast(ComplexArray, Xs.conj() * (phase1 * phase2)[None, :])
+        Xs = Xs.conj() * (phase1 * phase2)[None, :]
 
     return Xs, select_list
 

src/quantumhall_matrixelements/exchange_legendre.py

@@ -15,6 +15,7 @@
 
     ComplexArray = NDArray[np.complex128]
     RealArray = NDArray[np.float64]
+    BoolArray = NDArray[np.bool_]
     IntArray = NDArray[np.int64]
     Int8Array = NDArray[np.int8]
 
@@ -84,7 +85,7 @@ class LegendrePrecompute:
     # Only used for G values where the Bessel oscillations are resolvable.
     lag_J0w: RealArray | None      # (nG_lag, nlag) = J_0(arg) * wg
     lag_L_nm: RealArray | None     # (nmax, nlag) = L_p^0(xg) for p=0..nmax-1
-    lag_mask: RealArray | None     # (nG,) bool — True where Gauss-Laguerre is used
+    lag_mask: BoolArray | None     # (nG,) bool — True where Gauss-Laguerre is used
 
 
 # ---------------------------------------------------------------------------
@@ -189,7 +190,7 @@ def _build_legendre_precompute(
     # the Gauss-Laguerre nodes. For large |G|, fall back to mapped GL.
     lag_J0w: RealArray | None = None
     lag_L_nm: RealArray | None = None
-    lag_mask: RealArray | None = None
+    lag_mask: BoolArray | None = None
     if is_coulomb:
         nlag_eff = min(max(int(nlag), 2 * nmax), 350)
         xg, wg = sps.roots_genlaguerre(nlag_eff, -0.5)

src/quantumhall_matrixelements/exchange_ogata.py

@@ -717,8 +717,8 @@ def _per_g_max_abs(arr: ComplexArray) -> RealArray:
                     # Group by ds to reuse WB_ds[ds]
                     for ds_val in np.unique(ds_b):
                         ds_val = int(ds_val)
-                        WB = WB_ds[ds_val]
-                        if WB is None:
+                        WB_opt = WB_ds[ds_val]
+                        if WB_opt is None:
                             # This ds wasn't precomputed for this absN (shouldn't happen; be safe).
                             power = (ds_val - 1) if is_coulomb else ds_val
                             base_real = np.exp(common_og + float(power) * logu_minus_og)
@@ -728,6 +728,8 @@ def _per_g_max_abs(arr: ComplexArray) -> RealArray:
                                 else (base_real * Veff_og) * W_og
                             )
                             WB_ds[ds_val] = WB
+                        else:
+                            WB = WB_opt
 
                         mask = (ds_b == ds_val)
                         if not np.any(mask):
@@ -787,7 +789,7 @@ def _per_g_max_abs(arr: ComplexArray) -> RealArray:
     if sign_magneticfield == 1:
         phase1 = 1 - 2 * ((sel_n1 - sel_m1) & 1)
         phase2 = 1 - 2 * ((sel_n2 - sel_m2) & 1)
-        Xs = cast(ComplexArray, Xs.conj() * (phase1 * phase2)[None, :])
+        Xs = Xs.conj() * (phase1 * phase2)[None, :]
 
     return Xs, select_list
 

src/quantumhall_matrixelements/fock.py

@@ -8,8 +8,8 @@
 from numpy.typing import NDArray
 
 from .exchange_hankel import get_exchange_kernels_hankel
-from .exchange_ogata import get_exchange_kernels_Ogata
 from .exchange_laguerre import get_exchange_kernels_laguerre
+from .exchange_ogata import get_exchange_kernels_Ogata
 
 ComplexArray = NDArray[np.complex128]
 RealArray = NDArray[np.float64]

tests/test_coulomb_analytic_general.py

@@ -3,7 +3,10 @@
 import mpmath as mp
 import numpy as np
 
-from quantumhall_matrixelements.exchange_laguerre import QuadratureParams, build_exchange_fock_precompute
+from quantumhall_matrixelements.exchange_laguerre import (
+    QuadratureParams,
+    build_exchange_fock_precompute,
+)
 
 
 def _numeric_X_element(pre, g: int, n1: int, m1: int, n2: int, m2: int) -> complex:

tests/test_exchange_laguerre.py

@@ -1,8 +1,15 @@
 import numpy as np
 import pytest
 
-from quantumhall_matrixelements import build_fockmatrix_apply, get_exchange_kernels_compressed, get_fockmatrix_constructor
-from quantumhall_matrixelements.exchange_laguerre import QuadratureParams, build_exchange_fock_precompute
+from quantumhall_matrixelements import (
+    build_fockmatrix_apply,
+    get_exchange_kernels_compressed,
+    get_fockmatrix_constructor,
+)
+from quantumhall_matrixelements.exchange_laguerre import (
+    QuadratureParams,
+    build_exchange_fock_precompute,
+)
 
 
 def _random_hermitian_rho(nG: int, nmax: int, seed: int = 0) -> np.ndarray:

tests/test_exchange_legendre.py

@@ -1,8 +1,8 @@
 """Internal regression tests for the Gauss-Legendre backend module."""
 import numpy as np
 
-from quantumhall_matrixelements.exchange_legendre import get_exchange_kernels_GaussLegendre
 from quantumhall_matrixelements._materialize import materialize_full_tensor
+from quantumhall_matrixelements.exchange_legendre import get_exchange_kernels_GaussLegendre
 
 
 def test_legendre_basic_shape():