Skip to content

Commit f106c3f

Browse files
forgotten nit
1 parent 75e4a86 commit f106c3f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

spell/star-spell-reviewer-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ This section outlines the review process and provides concrete action items for
151151
### StarGuard execution
152152
- [ ] IF a [StarGuard module](https://github.com/sky-ecosystem/star-guard) is onboarded for this Prime Agent, the following additional checks are done:
153153
- [ ] The spell exposes view-only interface `function isExecutable() external view returns (bool result)`.
154-
- [ ] `isExecutable` either simply returns `true` or implements additional logic communicated via the relevant forum post (e.g.: by describing "earliest launch date" or "office hours" logic, etc).
154+
- [ ] `isExecutable` either simply returns `true` or implements additional logic communicated via the relevant forum post (e.g., by describing "earliest launch date" or "office hours" logic, etc).
155155
- [ ] The test ensures the spell is executable before expiration (i.e. `isExecutable` outputs `true` before `StarGuard.maxDelay()` is passed).
156156
- [ ] Third-party actors can not take advantage of the fact that Spell will be executed in a later block than the Core spell, otherwise suggest `direct execution`.
157157
- [ ] IF Prime Agent spell can not be executed in a later block OR have to be executed sequentially to another Prime Agent spell, `direct execution` is clearly mentioned in the forum post together with elaborated explanation why it is needed.

0 commit comments

Comments
 (0)