Skip to content
This repository was archived by the owner on Nov 4, 2019. It is now read-only.

Commit 8da1096

Browse files
author
Ashley Walker
committed
It runs!
1 parent c397f62 commit 8da1096

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

scripts/3a_detect_features.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ def detect(project_dir, detection_options):
3232
detector_node = getNode('/config/detector', True)
3333
detector_node.setString('detector', detector)
3434
detector_node.setString('scale', scale)
35+
# TODO: Use concurrency, a que to decrease the processing time:
3536
if detector == 'SIFT':
3637
detector_node.setInt('sift_max_features', sift_max_features)
3738
elif detector == 'SURF':

scripts/lib/Matcher.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -629,6 +629,7 @@ def robustGroupMatches(self, image_list, K,
629629

630630
dist_stats = np.array(dist_stats)
631631
plt.plot(dist_stats[:,0], dist_stats[:,1], 'ro')
632+
# TODO: Make a feature switch to stop showing when using the project runner.
632633
plt.show()
633634

634635
# remove any match sets shorter than self.min_pairs (this shouldn't

scripts/project_runner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
explore
1616

1717
def standard_project(project_dir, camera, max_camera_angle, detection_options, matching_options, match_trig_options, optmize_options, mre_options, colocated_options, render_options, delaunay_group):
18+
# TODO: Find every part of the script that creates a popup or requires interaction, and make into a feature flag that can be turned off for a standard run.
19+
1820
# 1a-create-project.py
1921
print(" Creating the standard Project")
2022
create_project.new_project(project_dir)
@@ -133,8 +135,6 @@ def standard_project(project_dir, camera, max_camera_angle, detection_options, m
133135
# delaunay options:
134136
parser.add_argument('--delaunay-group', type=int, default=0, help='group index')
135137

136-
137-
138138
args = parser.parse_args()
139139

140140
detection_options = [args.detector, args.scale, args.sift_max_features,

0 commit comments

Comments
 (0)