chore(ci): use (Linux/macOS portable) temporary folder for template tests (probot#363)

Author: shaftoe

.github/workflows/test.yml

@@ -18,9 +18,8 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node }}
-      - run: npm install
+      - run: npm ci
       - run: npm run build
-      - run: npm run test:clean
       # XXX: might be possible to parallelize each template test too, .e.g. `npm run test:template ${{ matrix.template }}`
       - run: npm run test
 

.gitignore

@@ -12,7 +12,6 @@ yarn.lock
 
 # Test-related generated folders
 coverage
-tmp-test
 
 # Miscellaneous
 .DS_Store

package.json

@@ -12,7 +12,6 @@
   "scripts": {
     "test": "./script/test-all-templates.sh",
     "test:template": "./script/test-template.sh",
-    "test:clean": "rimraf tmp-test",
     "lint": "prettier --ignore-path .gitignore --check '**/*.{js,ts,json,yml,md}'",
     "lint:fix": "prettier --ignore-path .gitignore --write '**/*.{js,ts,json,yml,md}'",
     "dev": "tsc-watch --onFirstSuccess \"npm run dev:make-exec\"",

script/test-template.sh

@@ -5,7 +5,7 @@ set -o pipefail  # Exit when any program execution in a pipeline breaks
 
 readonly APP="./bin/create-probot-app.js"
 readonly TEMPLATE=$1
-readonly TEST_FOLDER="./tmp-test/${TEMPLATE}"
+readonly TEST_FOLDER=$(mktemp -d -t cpa-XXXXXXXXXX)
 readonly LOGFILENAME="test.output"
 readonly LOGFILE="${TEST_FOLDER}/${LOGFILENAME}"