Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

部分代码可以删除 #7

Open
tnqiang opened this issue Sep 8, 2018 · 2 comments
Open

部分代码可以删除 #7

tnqiang opened this issue Sep 8, 2018 · 2 comments

Comments

@tnqiang
Copy link

tnqiang commented Sep 8, 2018

矩阵的加、减操作在渲染中用不到,可以考虑删除;

@emmanuel-deloget
Copy link

Hello,

Sorry if I answer in English, and hopefully Google Translate helped me to correctly understand the GH issue here (tanslation cames as "Matrix addition and subtraction operations are not used in rendering, you can consider deleting").

Please keep them, as if they are not present you'll force your users to re-implement them. Matrix substraction/addition may not be used during rendering, yet they may be used by a client application. Since the operation is trivial and the code is quite easy to read/check, it does no harm to keep it.

Best regards,

-- Emmanuel

@skywind3000
Copy link
Owner

skywind3000 commented Apr 20, 2019

They will be kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants