Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping file types between slack and slackevents #1053

Open
abustany opened this issue Apr 8, 2022 · 1 comment
Open

Overlapping file types between slack and slackevents #1053

abustany opened this issue Apr 8, 2022 · 1 comment
Labels
proposal

Comments

@abustany
Copy link
Contributor

abustany commented Apr 8, 2022

What's the rationale behind having two slightly different file types, one in the root package and one in slackevents? Would a PR to merge them have a chance to be accepted?
@ArcticSnowman
Copy link

I agree there are several types that are identical and could be combined into a single definition.
I trying to add SocketMode support to an app that works with RTM and I'm having to write little convertor function to map slackevent.Something to slack.Something rather than just having a single definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abustany @kanata2 @ArcticSnowman