This plugin uses rolldown-vite, which is no longer supported

[dverbru]

First, I have to say that I found surprising that this plugin is not using stable Vite 7, but rolldown-vite. Although quite complete, rolldown-vite was always considered experimental. Maybe this package could have been named piral-cli-rolldown-vite :)

Anyway, what matters the most now is that, since rolldown-vite was merged into Vite 8, it is no longer maintained, and the bugs that it still has, won't be fixed. We already hit one of such cases. See vitejs/rolldown-vite#513 (comment).

My proposal to solve the current situation is:

• Create a piral-cli-vite8 plugin
• Release a breaking v2 of this package depending on the stable Vite v7
• Deprecate v1 and recommend migrating to one of the two options above

[PvH-SPC]

Whats the plan here, i add to add "vite": "npm:rolldown-vite@^7" to my package to fix i think?

Also why is this a 1.0.0 release, not aligning with the 1.10.2 version?

[dverbru]

Last week Vite 8 was announced as stable: https://vite.dev/blog/announcing-vite8.html

At this point, the easiest way forward I suppose it is to create a piral-cli-vite8 superseding this plugin. What do you think @FlorianRappl?

[FlorianRappl]

Yes, that is the plan.

I am not sure why it surprises you that it uses rolldown-vite - it's written in the README: https://github.com/smapiot/piral-cli-vite7/tree/develop/packages/piral-cli-vite7#using

Vite 7 was totally uninteresting - only interesting part was the perf. gain by using rolldown instead of rollup. Therefore, it was a sound decision.

[FlorianRappl]

Also why is this a 1.0.0 release, not aligning with the 1.10.2 version?

I am not sure to what version you refer to (piral? but this here is an independent package - its not in the monorepo and does not follow the same version. Otherwise, we would need to put it in the monorepo. However, this is / and always was the same behavior across all non-monorepo packages; so not really surprising. It's v1 and therefore v1-compatible.

[dverbru]

Yes, that is the plan.

Perfect, thank you! And I see that the new plugin is available already! I will give it a shot.

I am not sure why it surprises you that it uses rolldown-vite - it's written in the README: https://github.com/smapiot/piral-cli-vite7/tree/develop/packages/piral-cli-vite7#using

Yes, eventually I found that other README deeper in the repository, but it is not mentioned on the main project README. For what it is worth, another dev in my team who tried to use this plugin first didn't find that obvious either.

Vite 7 was totally uninteresting

Agree. Our interest in adopting it was as a stepping stone towards Vite 8, but now we can jump directly to v8, so there is no point any more :)

[FlorianRappl]

Yes, the interesting part was rolldown (i.e., as a stepping stone to Vite 8) so that's why our Vite 7 plugin used it directly.

Right now that Vite 8 version is totally untested. It might not even integrate as Vite 8 is purely ESM (therefore the CLI plugin is purely ESM) and we require the CLI plugin. It might be that support only comes with the next version of the piral-cli. We will most likely test and release this end of this week.

[FlorianRappl]

FYI: Got tested, everything should work now - hence piral-cli-vite8 is now released.