[PRODCRE-1671] Remove env_artifact (#20773)

* working version

* clean go mod

* add copilot's suggestion

Author: Tofel

core/scripts/cre/environment/environment/environment.go

@@ -477,6 +477,15 @@ func startCmd() *cobra.Command {
 			fmt.Print(libformat.PurpleText("\nEnvironment setup completed successfully in %.2f seconds\n\n", time.Since(provisioningStartTime).Seconds()))
 			fmt.Print("To terminate execute:`go run . env stop`\n\n")
 
+			addresses, aErr := output.CreEnvironment.CldfEnvironment.DataStore.Addresses().Fetch()
+			if aErr != nil {
+				return errors.Wrap(aErr, "failed to fetch addresses from datastore")
+			}
+
+			stErr := in.SetAddresses(addresses)
+			if stErr != nil {
+				return errors.Wrap(stErr, "failed to set addresses on Config")
+			}
 			storeErr := in.Store(envconfig.MustLocalCREStateFileAbsPath(relativePathToRepoRoot))
 			if storeErr != nil {
 				return errors.Wrap(storeErr, "failed to store local CRE state")
@@ -641,14 +650,6 @@ func stopCmd() *cobra.Command {
 				} else {
 					framework.L.Info().Msgf("removed local CRE state file: %s", creStateFile)
 				}
-
-				envArtifactFile := creenv.MustEnvArtifactAbsPath(relativePathToRepoRoot)
-				eErr := os.Remove(envArtifactFile)
-				if eErr != nil {
-					framework.L.Warn().Msgf("failed to remove local CRE environment artifact file: %s", eErr)
-				} else {
-					framework.L.Info().Msgf("removed local CRE environment artifact file: %s", envArtifactFile)
-				}
 			}
 
 			fmt.Println("Environment stopped successfully")
@@ -745,26 +746,6 @@ func StartCLIEnvironment(
 		return nil, fmt.Errorf("failed to setup test environment: %w", setupErr)
 	}
 
-	capabilitiesContractFactoryFunctions := []cre.CapabilityRegistryConfigFn{}
-	for _, cap := range capabilities {
-		capabilitiesContractFactoryFunctions = append(capabilitiesContractFactoryFunctions, cap.CapabilityRegistryV1ConfigFn())
-	}
-
-	artifactPath, artifactErr := creenv.DumpArtifact(
-		creenv.MustEnvArtifactAbsPath(relativePathToRepoRoot),
-		*universalSetupOutput.Dons,
-		universalSetupOutput.CreEnvironment,
-		*in.JD.Out,
-		in.NodeSets,
-		capabilitiesContractFactoryFunctions,
-	)
-
-	if artifactErr != nil {
-		testLogger.Error().Err(artifactErr).Msg("failed to generate env artifact")
-	} else {
-		testLogger.Info().Msgf("Environment artifact saved to %s", artifactPath)
-	}
-
 	return universalSetupOutput, nil
 }
 

core/scripts/cre/environment/environment/examples.go

@@ -55,7 +55,7 @@ func deployAndVerifyExampleWorkflowCmd() *cobra.Command {
 				workflowRegistryAddress = workflowRegistryAddressFlag
 				contractsVersion = semver.MustParse(contractsVersionFlag)
 			} else {
-				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry.String())
+				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry)
 				if addrErr != nil {
 					return errors.Wrap(addrErr, "❌ failed to get workflow registry address from state file")
 				}

core/scripts/cre/environment/environment/swap.go

@@ -103,19 +103,15 @@ func swapCapability(ctx context.Context, capabilityFlag, binaryPath string, forc
 		return errors.Wrap(setErr, "failed to set CTF_CONFIGS environment variable")
 	}
 
-	config, loadErr := framework.Load[envconfig.Config](nil)
+	config := &envconfig.Config{}
+	loadErr := config.Load(os.Getenv("CTF_CONFIGS"))
 	if loadErr != nil {
 		return errors.Wrap(loadErr, "failed to load CTF config")
 	}
 
-	envArtifact, artErr := creenv.ReadEnvArtifact(creenv.MustEnvArtifactAbsPath(relativePathToRepoRoot))
-	if artErr != nil {
-		return errors.Wrap(artErr, "failed to read environment artifact")
-	}
-
 	cldLogger := cldlogger.NewSingleFileLogger(nil)
 
-	creEnvironment, dons, loadErr := creenv.BuildFromSavedState(ctx, cldLogger, config, envArtifact)
+	creEnvironment, dons, loadErr := creenv.BuildFromSavedState(ctx, cldLogger, config)
 	if loadErr != nil {
 		return errors.Wrap(loadErr, "failed to load environment")
 	}
@@ -447,8 +443,4 @@ func envIsRunningPreRunFunc(cmd *cobra.Command, args []string) {
 	if !envconfig.LocalCREStateFileExists(relativePathToRepoRoot) {
 		framework.L.Fatal().Str("Expected location", envconfig.MustLocalCREStateFileAbsPath(relativePathToRepoRoot)).Msg("Local CRE state file does not exist. Please start the environment first.")
 	}
-
-	if !creenv.EnvArtifactFileExists(relativePathToRepoRoot) {
-		framework.L.Fatal().Str("Expected location", creenv.MustEnvArtifactAbsPath(relativePathToRepoRoot)).Msg("Environment artifact file does not exist. Please start the environment first.")
-	}
 }

core/scripts/cre/environment/environment/workflow.go

@@ -17,12 +17,13 @@ import (
 	"github.com/spf13/cobra"
 
 	"github.com/smartcontractkit/chainlink-deployments-framework/datastore"
+	"github.com/smartcontractkit/chainlink-deployments-framework/deployment"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
 	"github.com/smartcontractkit/chainlink-testing-framework/seth"
 
 	keystone_changeset "github.com/smartcontractkit/chainlink/deployment/keystone/changeset"
-	"github.com/smartcontractkit/chainlink/system-tests/lib/cre/contracts"
 	"github.com/smartcontractkit/chainlink/system-tests/lib/cre/environment"
+	envconfig "github.com/smartcontractkit/chainlink/system-tests/lib/cre/environment/config"
 	creworkflow "github.com/smartcontractkit/chainlink/system-tests/lib/cre/workflow"
 )
 
@@ -166,7 +167,7 @@ func deployWorkflowCmd() *cobra.Command {
 			if workflowRegistryAddressFlag != "" {
 				workflowRegistryAddress = workflowRegistryAddressFlag
 			} else {
-				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry.String())
+				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry)
 				if addrErr != nil {
 					return errors.Wrap(addrErr, "❌ failed to get workflow registry address from state file")
 				}
@@ -179,7 +180,7 @@ func deployWorkflowCmd() *cobra.Command {
 			if capabilitiesRegistryAddressFlag != "" {
 				capabilitiesRegistryAddress = capabilitiesRegistryAddressFlag
 			} else {
-				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.CapabilitiesRegistry.String())
+				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.CapabilitiesRegistry)
 				if addrErr != nil {
 					return errors.Wrap(addrErr, "❌ failed to get capabilities registry address from state file")
 				}
@@ -259,7 +260,7 @@ func deleteWorkflowCmd() *cobra.Command {
 				workflowRegistryAddress = workflowRegistryAddressFlag
 				contractsVersion = semver.MustParse(contractsVersionFlag)
 			} else {
-				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry.String())
+				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry)
 				if addrErr != nil {
 					return errors.Wrap(addrErr, "❌ failed to get workflow registry address from state file")
 				}
@@ -340,7 +341,7 @@ func deleteAllWorkflowsCmd() *cobra.Command {
 				workflowRegistryAddress = workflowRegistryAddressFlag
 				contractsVersion = semver.MustParse(contractsVersionFlag)
 			} else {
-				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry.String())
+				addrRef, addrErr := addressRefFromStateFile(keystone_changeset.WorkflowRegistry)
 				if addrErr != nil {
 					return errors.Wrap(addrErr, "❌ failed to get workflow registry address from state file")
 				}
@@ -541,24 +542,23 @@ func isBase64Content(content string) bool {
 	return err == nil
 }
 
-func addressRefFromStateFile(contractType string) (datastore.AddressRef, error) {
-	envArtifact, artErr := environment.ReadEnvArtifact(environment.MustEnvArtifactAbsPath(relativePathToRepoRoot))
-	if artErr != nil {
-		return datastore.AddressRef{}, errors.Wrap(artErr, "failed to read environment artifact")
+func addressRefFromStateFile(contractType deployment.ContractType) (*datastore.AddressRef, error) {
+	in := &envconfig.Config{}
+	err := in.Load(envconfig.MustLocalCREStateFileAbsPath(relativePathToRepoRoot))
+	if err != nil {
+		return nil, errors.Wrap(err, "failed to load state file")
 	}
 
-	ds := datastore.NewMemoryDataStore()
-	for _, addrRef := range envArtifact.AddressRefs {
-		addErr := ds.AddressRefStore.Add(addrRef)
-		if addErr != nil {
-			return datastore.AddressRef{}, fmt.Errorf("failed to add address ref to datastore %v: %w", addrRef, addErr)
-		}
+	addresses, aErr := in.GetAddresses()
+	if aErr != nil {
+		return nil, errors.Wrap(aErr, "failed to get addresses from cached input")
 	}
 
-	contractVersion, ok := envArtifact.ContractVersions[contractType]
-	if !ok {
-		return datastore.AddressRef{}, fmt.Errorf("no contract version for contract type %s found in environment artifact", contractType)
+	for _, addrRef := range addresses {
+		if datastore.ContractType(contractType) == addrRef.Type {
+			return &addrRef, nil
+		}
 	}
 
-	return contracts.MustGetAddressRefFromDataStore(ds.Seal(), envArtifact.RegistryChainSelector, contractType, contractVersion, ""), nil
+	return nil, fmt.Errorf("did not find any address for %s contract", contractType)
 }

system-tests/lib/cre/environment/config/config.go

@@ -1,6 +1,7 @@
 package config
 
 import (
+	"encoding/json"
 	"fmt"
 	"maps"
 	"os"
@@ -14,6 +15,7 @@ import (
 	"github.com/pelletier/go-toml/v2"
 	"github.com/pkg/errors"
 
+	"github.com/smartcontractkit/chainlink-deployments-framework/datastore"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
 	billingplatformservice "github.com/smartcontractkit/chainlink-testing-framework/framework/components/dockercompose/billing_platform_service"
@@ -27,6 +29,33 @@ import (
 	"github.com/smartcontractkit/chainlink/system-tests/lib/infra"
 )
 
+// GetAddresses returns the addresses as datastore.AddressRef slice
+func (c *Config) GetAddresses() ([]datastore.AddressRef, error) {
+	addresses := make([]datastore.AddressRef, len(c.Addresses))
+	for i, addr := range c.Addresses {
+		in := []byte(addr)
+		var addrRef datastore.AddressRef
+		if err := json.Unmarshal(in, &addrRef); err != nil {
+			return nil, fmt.Errorf("failed to unmarshal address at index %d: %w", i, err)
+		}
+		addresses[i] = addrRef
+	}
+	return addresses, nil
+}
+
+// SetAddresses sets the addresses from datastore.AddressRef slice
+func (c *Config) SetAddresses(refs []datastore.AddressRef) error {
+	c.Addresses = make([]string, len(refs))
+	for i, ref := range refs {
+		asBytes, err := json.Marshal(ref)
+		if err != nil {
+			return fmt.Errorf("failed to marshal address at index %d: %w", i, err)
+		}
+		c.Addresses[i] = string(asBytes)
+	}
+	return nil
+}
+
 type Config struct {
 	Blockchains       []*blockchain.Input             `toml:"blockchains" validate:"required"`
 	NodeSets          []*cre.NodeSet                  `toml:"nodesets" validate:"required"`
@@ -36,6 +65,7 @@ type Config struct {
 	FakeHTTP          *fake.Input                     `toml:"fake_http" validate:"required"`
 	S3ProviderInput   *s3provider.Input               `toml:"s3provider"`
 	CapabilityConfigs map[string]cre.CapabilityConfig `toml:"capability_configs"` // capability flag -> capability config
+	Addresses         []string                        `toml:"addresses"`
 
 	mu     sync.Mutex
 	loaded bool