Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Overrider within ID enabled EAs #1963

Open
justinkaseman opened this issue Jun 14, 2022 · 1 comment
Open

Use Overrider within ID enabled EAs #1963

justinkaseman opened this issue Jun 14, 2022 · 1 comment

Comments

@justinkaseman
Copy link
Collaborator

Description

External Adapters accept overrides as input parameters or as hardcoded configuration within the EA. These traditionally are used for symbol to symbol conversions when a data provider requires input that isn't the standard symbol. (e.g. BTC -> BITCOIN). Certain data providers accept queries using a currency's id or cid. As we move more towards ids as a best practice we would like these adapters to handle overrides more elegantly.

We have created the Overrider class that handles both symbol->symbol and symbol->id overrides.
It was added to Coingecko and Coinpaprika, but there are other adapters that could utilize it.

Acceptance Criteria

  1. Identify External Adapters that accept ids or cids in input parameters (e.g. Coinmarketcap)
  2. Implement the Overrider from the EA framework to handle symbol -> id overrides for each of these EAs.

@KuphJr will be able to help provide an introduction on the Overrider feature.

@justinkaseman
Copy link
Collaborator Author

High priority adapters:

  • nomics
  • coinmarketcap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant