address comments

Author: FelixFan1992

README.md

@@ -38,7 +38,8 @@ Up-to-date documentation on Chainlink Functions can be found [here](https://docs
 
 Install Node.js version `18.18.0` or higher _and_ Deno version `1.36.0` or higher.
 
-Starting from ABOVE 0.3.2, Anvil is required to run local tests. A `Makefile` is included to automate the installation and build process. Simply run `make install` to install Anvil and all npm packages.
+For version 0.3.2 and above of this functions-toolkit package, Anvil is required to run local tests. A `Makefile` is included to automate the installation and build process. Simply run `make install` to install Anvil and all npm packages.
+If you already have anvil and/or foundry (the Foundry toolchain) installed, you would not need to run this. But you may want to run `foundryup` to update your version and `npm install` to install packages.
 
 Chainlink Functions requires signing a terms of service agreement before creating a billing subscription. See this [getting started](https://docs.chain.link/chainlink-functions/getting-started) section in the docs.
 
@@ -596,7 +597,7 @@ return Functions.encodeString(escape("$hello*world?"));
 ### Local Functions Testnet
 
 > **Note**
-> Starting from above 0.3.2, Anvil is REQUIRED to use `localFunctionsTestnet`. Please run `make install` to install Anvil and all the necessary dependencies.
+> For version 0.3.2 and above of this functions-toolkit package, Anvil is REQUIRED to use `localFunctionsTestnet`. Please run `make install` to install Anvil and all the necessary dependencies. If you already have anvil and/or foundry (the Foundry toolchain) installed, you would not need to run this. But you may want to run `foundryup` to update your version and `npm install` to install packages.
 
 For debugging smart contracts and the end-to-end request flow on your local machine, you can use the `localFunctionsTestnet` function. This creates a local testnet RPC node with a mock Chainlink Functions contracts. You can then deploy your own Functions consumer contract to this local network, create and manage subscriptions, and send requests. Request processing will simulate the behavior of an actual DON where the request is executed 4 times and the discrete median response is transmitted back to the consumer contract. (Note that Chainlink Functions uses the following calculation to select the discrete median response: `const medianResponse = responses[responses.length - 1) / 2]`).
 

src/localFunctionsTestnet.ts

@@ -37,17 +37,26 @@ export const startLocalFunctionsTestnet = async (
   simulationConfigPath?: string,
   port = 8545,
 ): Promise<LocalFunctionsTestnet> => {
-  const anvil = createAnvil({
-    port,
-    chainId: 1337,
-  })
+  let anvil: any
+  try {
+    anvil = createAnvil({
+      port,
+      chainId: 1337,
+    })
+  } catch (error) {
+    console.error('Error creating Anvil instance: ', error)
+    console.error(
+      'Please refer to README about how to properly set up the environment, including anvil.',
+    )
+    throw error
+  }
 
   await anvil.start()
   console.log(`Anvil started on port ${port} with chain ID 1337`)
 
   let privateKey = process.env.PRIVATE_KEY
   if (!privateKey) {
-    // this is a private key provided by anvil
+    // this is a hardcoded private key provided by anvil
     privateKey = 'ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80'
   }
 

test/utils/index.ts

@@ -74,22 +74,17 @@ const createTestWallets = (port = 8545): Wallet[] => {
   const wallets: Wallet[] = []
   const provider = new providers.JsonRpcProvider(`http://127.0.0.1:${port}`)
 
-  // these are random private keys provided by anvil
-  wallets.push(
-    new Wallet('59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d').connect(
-      provider,
-    ),
-  )
-  wallets.push(
-    new Wallet('5de4111afa1a4b94908f83103eb1f1706367c2e68ca870fc3fb9a804cdab365a').connect(
-      provider,
-    ),
-  )
-  wallets.push(
-    new Wallet('7c852118294e51e653712a81e05800f419141751be58f605c371e15141b007a6').connect(
-      provider,
-    ),
-  )
+  // these are hardcoded private keys provided by anvil. you can see these private keys in the console output if you simply run `anvil`
+  // using these makes sure that these wallets are properly connected to Anvil local node
+  const privateKeys = [
+    '59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d',
+    '5de4111afa1a4b94908f83103eb1f1706367c2e68ca870fc3fb9a804cdab365a',
+    '7c852118294e51e653712a81e05800f419141751be58f605c371e15141b007a6',
+  ]
+
+  for (const privateKey of privateKeys) {
+    wallets.push(new Wallet(privateKey).connect(provider))
+  }
 
   return wallets
 }